Fix regression for catching empty tuple in except#21153
Open
hauntsaninja wants to merge 2 commits intopython:masterfrom
Open
Fix regression for catching empty tuple in except#21153hauntsaninja wants to merge 2 commits intopython:masterfrom
hauntsaninja wants to merge 2 commits intopython:masterfrom
Conversation
hauntsaninja
force-pushed
the
excempty
branch
2 times, most recently
from
d822ecf to
64c3d86
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
@ilevkivskyi can you help me understand why are the parallel tests are failing on this one? |
Member
|
I am already going to bed, didn't actually look, but judging from the test output, most likely this is a bug in ast-serialize (it is automatically used for parallel checking). |
Member
|
Yeah, quickly looked at |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
reviewed
Apr 3, 2026
| pass | ||
| [builtins fixtures/tuple.pyi] | ||
|
|
||
| [case testExceptWithMultipleTypes6_no_parallel] |
Member
There was a problem hiding this comment.
Could you please open an issue in ast_serialize tracker about this, and leave a comment above why this is skipped?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21152