gh-148695: Lint warnings in cases generator, ceval with GIL, and optimizer.#148696
Open
clin1234 wants to merge 4 commits intopython:mainfrom
Open
gh-148695: Lint warnings in cases generator, ceval with GIL, and optimizer.#148696clin1234 wants to merge 4 commits intopython:mainfrom
clin1234 wants to merge 4 commits intopython:mainfrom
Conversation
clin1234
requested review from
Fidget-Spinner,
ericsnowcurrently and
markshannon
as code owners
picnixz
reviewed
Apr 19, 2026
| def push_cache(self, op_name: str, cached_items:list[str], outputs: int, out: CWriter) -> None: | ||
| for i, name in enumerate(cached_items): | ||
| out.start_line() | ||
| if (op_name == "_CALL_TYPE_1" and outputs == 2) \ |
Member
There was a problem hiding this comment.
I think this is too fragile. Can't we just have a maybe unused attribute instead? and what about clang attributes? (AFAICT this is a GCC attribute only).
I do not think the unused variable warnings need to be suppressed.
Contributor
Author
There was a problem hiding this comment.
Can the Py_UNUSED macro be applied to lvalue variables?
Member
There was a problem hiding this comment.
I don't think so. But again is there a need to suppress such warnings? we provide no guarantee for -Wall -Werror/-Wpedantic and I do not see value in suppressing unused variable warninga in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.