gh-148119: Refactor get_type_attr_as_size to improve error handling in structseq.c#148120
Merged
kumaraditya303 merged 3 commits intopython:mainfrom Apr 6, 2026
Merged
gh-148119: Refactor get_type_attr_as_size to improve error handling in structseq.c#148120kumaraditya303 merged 3 commits intopython:mainfrom
get_type_attr_as_size to improve error handling in structseq.c#148120kumaraditya303 merged 3 commits intopython:mainfrom
Conversation
…ndling in `structseq.c`
aisk
reviewed
Apr 5, 2026
aisk
approved these changes
Apr 5, 2026
Member
This PR fixes a bug and changes user facing behavior, so it likely needs a news entry. However, since this bug is unlikely to occur in practice, I'm not entirely sure whether one is necessary. |
kumaraditya303
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add skip-news label