Termios module largely untested

[tonybaloney]

BPO	36821
Nosy	@tonybaloney

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tonybaloney'
closed_at = None
created_at = <Date 2019-05-06.22:47:32.674>
labels = ['3.8', 'type-feature', 'tests']
title = 'Termios module largely untested'
updated_at = <Date 2019-05-06.22:47:59.957>
user = 'https://github.com/tonybaloney'

bugs.python.org fields:

activity = <Date 2019-05-06.22:47:59.957>
actor = 'anthonypjshaw'
assignee = 'anthonypjshaw'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2019-05-06.22:47:32.674>
creator = 'anthonypjshaw'
dependencies = []
files = []
hgrepos = []
issue_num = 36821
keywords = []
message_count = 2.0
messages = ['341656', '341657']
nosy_count = 1.0
nosy_names = ['anthonypjshaw']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue36821'
versions = ['Python 3.8']

Linked PRs

• gh-81002: Add tests for termios #110386
• [3.12] gh-81002: Add tests for termios (GH-110386) #110619
• [3.11] gh-81002: Add tests for termios (GH-110386) #110620

[tonybaloney]

I noticed that the termios.c module is largely untested.

There is some coverage via test_pty, test_ioctl and test_getpass, but there is nothing to cover regression and the behaviours in the module functions.

Tests are required for:

• termios.tcgetattr()
• termios.tcsetattr()
• termios.tcsendbreak()
• termios.tcdrain()
• termios.tcflush()
• termios.tcflow()

[tonybaloney]

This could be a good issue for the PyCon sprints, otherwise I'm happy to implement it