Merged
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-components/p00cmll6e |
auareyou
approved these changes
Mar 9, 2020
auareyou
left a comment
auareyou
left a comment
There was a problem hiding this comment.
I didn't realize those were two different components. I was assuming SideNav was the same as vertical navigation. I do see how the orange background wouldn't work in this component with all the grey backgrounds. I'm happy to leave as is and look into a bit more in depth later. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the SideNav with the new visual refresh styles! So far I've just updated the orange color that we're using. @auareyou I wasn't sure if there are any other changes that should be made? I didn't see anything in the Figma file under the navigation frame that corresponds to our SideNav (there's a vertical navigation component but I think that is corresponding to the Menu Component.
The current SideNav has a grey background, and selected items turn white. Should we keep those styles and just update the orange color?
Primer CSS SideNav: https://primer.style/css/components/navigation#side-nav
Primer Components SideNav: https://primer.style/components/SideNav