Skip to content

Fixed typos#9

Merged
mdo merged 1 commit intoprimer:masterfrom
pborreli:typos
Mar 27, 2015
Merged

Fixed typos#9
mdo merged 1 commit intoprimer:masterfrom
pborreli:typos

Conversation

@pborreli
Copy link
Copy Markdown
Contributor

No description provided.

@cvrebert cvrebert mentioned this pull request Mar 23, 2015
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alignment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, thx !, fixing it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 👍

@reidrac reidrac mentioned this pull request Mar 24, 2015
@mdo mdo added the docs label Mar 24, 2015
mdo added a commit that referenced this pull request Mar 24, 2015
@pborreli
Copy link
Copy Markdown
Contributor Author

is there an issue with this PR ? do I need to do something before it's accepted ?

@nickserv
Copy link
Copy Markdown
Contributor

👍 Looks good to me.

@mdo mdo added this to the v2.0.3 milestone Mar 27, 2015
@mdo
Copy link
Copy Markdown
Contributor

mdo commented Mar 27, 2015

Howdy—thanks for the pull request, @pborreli!

Before we can merge your changes, we need you to review our Contributor License Agreement (CLA). We think of CLAs as an open source software license between you and the project, letting us and other users know that we have permission to use the code you contribute.

At the bottom of the pull request, you'll see the note about a failed test. Just click the Details link, review the CLA, and sign off at the bottom.

Questions? Just holler—I'm here to help :).

<3

@mdo mdo mentioned this pull request Mar 27, 2015
Closed
@pborreli
Copy link
Copy Markdown
Contributor Author

done

@pborreli
Copy link
Copy Markdown
Contributor Author

wow i generally don't like CLA but how it is integrated here makes it so easy !

@mdo
Copy link
Copy Markdown
Contributor

mdo commented Mar 27, 2015

Woohoo, and thank you for the changes!

mdo added a commit that referenced this pull request Mar 27, 2015
@mdo mdo merged commit ff8d28f into primer:master Mar 27, 2015
@mdo mdo mentioned this pull request Mar 27, 2015
@pborreli pborreli deleted the typos branch March 28, 2015 01:58
shawnbot pushed a commit that referenced this pull request Oct 9, 2017
Update ava to version 0.17.0 🚀
emilybrick pushed a commit that referenced this pull request Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants