Reorganize and lint scripts; remove unused dev dependencies#890
Merged
shawnbot merged 13 commits intorelease-13.0.0from Sep 10, 2019
Merged
Reorganize and lint scripts; remove unused dev dependencies#890shawnbot merged 13 commits intorelease-13.0.0from
shawnbot merged 13 commits intorelease-13.0.0from
Conversation
BREAKING CHANGE: the build directory is no longer included in the
distributed package. build/stats.json can be found at
dist/stats/primer.json, and `require('@primer/css/build')` references
should be rewritten to `require('@primer/css/dist/primer')`.
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-tidy-scripts-deps.primer.now.sh |
This was referenced Sep 10, 2019
Merged
shawnbot
changed the title
colebemis
approved these changes
Sep 10, 2019
Contributor
colebemis
left a comment
colebemis
left a comment
There was a problem hiding this comment.
Looks good to me! 👍 Always happy to see more deletions than additions 😄
This was referenced Dec 18, 2022
This was referenced Jan 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's time to clean house in the scripts directory and
devDependencies! Here's the deal:build/directory:build/build.css→dist/primer.cssbuild/build.json→dist/stats/primer.jsonbuild/index.js→dist/primer.js(themainfield inpackage.jsonwas updated in 12.0.0, sorequire('@primer/css')will continue to work the same)script/now have the.jsextension so that eslint can find them.lib/erb-to-html.jsis gone, as we aren't using it anymore in Doctocat. /cc @colebemis