Merged
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-deprecations-data.primer.now.sh |
zeke
reviewed
Sep 5, 2019
Contributor
zeke
left a comment
There was a problem hiding this comment.
Left a few little comments and suggestions, but overall this looks good!
Are you planning to add tests to validate the deprecations.json output?
colebemis
suggested changes
Sep 5, 2019
Contributor
colebemis
left a comment
There was a problem hiding this comment.
Looks good! 💯 Left a few comments. The only thing I feel strongly about is adding title front matter to the documentation page.
colebemis
reviewed
Sep 5, 2019
Co-Authored-By: Zeke Sikelianos <zeke@sikelianos.com>
This was referenced Dec 21, 2022
This was referenced Dec 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first stab at publishing deprecation data, as described in #740. Here's what accessing it looks like:
JSON
outputs:
See the Markdown docs (and the published page) for usage instructions.
Closes #740