Merged
Conversation
|
This pull request is automatically deployed with Now. |
1 task
shawnbot
force-pushed
the
include-octicon-css
branch
from
181c016 to
3e12aca
Compare
shawnbot
force-pushed
the
include-octicon-css
branch
from
3e12aca to
e67c174
Compare
jonrohan
reviewed
Aug 7, 2019
Member
jonrohan
left a comment
jonrohan
left a comment
There was a problem hiding this comment.
Checked it out on now, looks good 🚀
jonrohan
approved these changes
Aug 7, 2019
This was referenced Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @jonrohan in #845, we want to include the
.octiconstyles in the Primer CSS "core" bundle. I added an explicit import in the docs in #847, so if we merge this and still want to go that route, we can remove that JSimport.Update: I'm not sure how this will affect github/github, so I'm going to open a PR with a canary release and make sure things still work if I delete the duplicate
@importin that repo's stylesheets.