Skip to content

Include GitHub's stylesheet.css in Storybook head#849

Merged
vdepizzol merged 1 commit intoprimer:release-12.6.0from
vdepizzol:patch-2
Aug 6, 2019
Merged

Include GitHub's stylesheet.css in Storybook head#849
vdepizzol merged 1 commit intoprimer:release-12.6.0from
vdepizzol:patch-2

Conversation

@vdepizzol
Copy link
Copy Markdown
Contributor

A couple of Primer CSS components need GitHub's stylesheet.css to render correctly (I'm looking at you, dropdown). This adds it to the Storybook config directory along with preexisting stylesheet.js.

This fixes this:
Screen Shot 2019-07-29 at 13 09 03

So it renders as this:
Screen Shot 2019-07-29 at 13 08 36

/cc @primer/ds-core

A couple of Primer CSS components need GitHub's stylesheet.css to render correctly (I'm looking at you, dropdown). This adds it to the Storybook config directory along with preexisting stylesheet.js.
@vercel
Copy link
Copy Markdown

vercel bot commented Jul 29, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Copy link
Copy Markdown
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was a bug, but there might be a reason. @shawnbot?

Copy link
Copy Markdown
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to interfere with Storybook's styles since it's only rendered in previews. I think this works!

@shawnbot shawnbot mentioned this pull request Jul 30, 2019
11 tasks
@shawnbot shawnbot changed the base branch from master to release-12.6.0 August 5, 2019 20:37
@shawnbot
Copy link
Copy Markdown
Contributor

shawnbot commented Aug 5, 2019

@vdepizzol I set the base branch for this to #854, but something just occurred to me:

This probably won't work on primer.github.io/storybook because of github.com's CORS headers, which will prevent other domains from loading them in a browser. We might need to revive the mechanism that pulled down a static version of the github.com asset(s) to get this working, but for now it at least makes things easier for local development.

@vdepizzol
Copy link
Copy Markdown
Contributor Author

@shawnbot that makes sense! I didn't know primer.github.io/storybook existed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants