Merged
Conversation
|
This pull request is automatically deployed with Now. |
I think this is not needed anymore since the examples have a wrapper with `p-3`.
Merged
Contributor
|
Oh.. one more thing. Should the An alternative might be that the component doesn't have to know where it is and it can be added in a wrapper like: <div class="position-fixed bottom-0 left-0">
<div class="Toast">...</div>
</div>The nice thing about that would be that if there are multiple Toasts at the same time, they would just start to stack on top of each other.. and we don't really have to bother about queuing them or calculate their individual positions. |
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
`style="fill:currentcolor"` can be used for inline `<svg>`s
This is needed so that the Toast's margin's don't get collapsed and the example gets cropped.
Toasts v2.1
simurai
approved these changes
Jul 17, 2019
Contributor
simurai
left a comment
There was a problem hiding this comment.
I think this is good to go. 👍 We can always tweak it further after using it for a bit.
This was referenced Dec 18, 2022
This was referenced Dec 27, 2022
This was referenced Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I branched off of this initial branch so that we could preserve all the styles @ampinsk explored, and just focus on the
blockstyle in this one.Updates in this branch:
To Do: