Merged
Conversation
|
This pull request is automatically deployed with Now. |
Contributor
Author
|
Re: the staging alias, the docs suggest that staging deployments will be automatically aliased using the following pattern: But this URL doesn't seem to work: |
Contributor
Author
If only it were that simple! 😭 |
8 tasks
This was referenced Dec 15, 2022
This was referenced Dec 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This removes the
primer/deployaction in favor of using Now's GitHub integration, which has some distinct advantages:It uses the GitHub Deployments API, so the deployment links aren't buried in commit statuses.
It handles canceling in-progress builds if you push before they're done:
It apparently creates automatic staging aliases for each pull request. I'm curious to see if this PR gets one, because Select Menu component #808 didn't. 🤔
Let's see how this goes!