Skip to content

Add more responsive border utilities#775

Merged
shawnbot merged 13 commits intorelease-12.4.0from
more-border-utils
May 14, 2019
Merged

Add more responsive border utilities#775
shawnbot merged 13 commits intorelease-12.4.0from
more-border-utils

Conversation

@shawnbot
Copy link
Copy Markdown
Contributor

@shawnbot shawnbot commented Apr 30, 2019

This adds the following responsive border utilities:

  • .border-{breakpoint}-0 removes borders on all sides responsively, a la .border-0.
  • .border-{breakpoint} adds borders on all sides responsively, a la .border. I had this as .border-{breakpoint}-1, but removed the -1 suffix at @simurai's recommendation.
  • For consistency, I've also added .border-x for horizontal borders only.
  • The docs explain how all of the permutations work.

Closes #756

@shawnbot shawnbot requested a review from simurai April 30, 2019 16:34
@shawnbot shawnbot mentioned this pull request Apr 30, 2019
13 tasks
Copy link
Copy Markdown
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggestion to change the example. And not sure about the -1. Otherwise 👍 .

Co-Authored-By: shawnbot <shawn.allen@github.com>
@shawnbot shawnbot changed the base branch from release-12.3.0 to master May 9, 2019 20:46
@shawnbot shawnbot requested a review from simurai May 9, 2019 21:25
Copy link
Copy Markdown
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to 🚢 👍 .

@shawnbot shawnbot changed the base branch from master to release-12.4.0 May 14, 2019 20:25
@shawnbot shawnbot mentioned this pull request May 14, 2019
11 tasks
@shawnbot shawnbot merged commit 0a14c1c into release-12.4.0 May 14, 2019
@shawnbot shawnbot deleted the more-border-utils branch May 14, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants