Fix .social-count underline#48
Merged
mdo merged 2 commits intoprimer:masterfrom Mar 28, 2015
flovan:fix-social-count-underline
Merged
Fix .social-count underline#48mdo merged 2 commits intoprimer:masterfrom flovan:fix-social-count-underline
.social-count underline#48mdo merged 2 commits intoprimer:masterfrom
flovan:fix-social-count-underline
Conversation
`.social-count` elements get an underline when pressing down (`:active`), then dragging out of them.
scss/_buttons.scss
Outdated
There was a problem hiding this comment.
Opening curly brace { should be preceded by one space
Contributor
|
Howdy—thanks for the pull request, @flovan! Before we can merge your changes, we need you to review our Contributor License Agreement (CLA). We think of CLAs as an open source software license between you and the project, letting us and other users know that we have permission to use the code you contribute. At the bottom of the pull request, you'll see the note about a failed test. Just click the Details link, review the CLA, and sign off at the bottom. Questions? Just holler—I'm here to help :). <3 |
Author
|
Done! |
Contributor
|
Thanks! <3 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.social-countelements get an underline when pressing down (:active), then dragging out. I didn't see this behaviour in any of the other buttons or text-buttons, but feel free to close this PR if this was a design-choice, rather than something that was overlooked.Also, I did not know how to "add tests", but maybe that isn't needed for such a small change.