Skip to content

Remove primer-page-headers package#439

Merged
shawnbot merged 2 commits intorelease-11.0.0from
rm-primer-page-headers
Oct 17, 2018
Merged

Remove primer-page-headers package#439
shawnbot merged 2 commits intorelease-11.0.0from
rm-primer-page-headers

Conversation

@sophshep
Copy link
Copy Markdown

@sophshep sophshep commented Jan 18, 2018

This PR removes all code for the unneeded primer-page-headers package.

This package defined jumbotron styles, which are no longer needed because we can achieve everything with utility classes 🎉

Corresponding PR in GitHub: https://github.com/github/github/pull/84036
cc/ @primer/ds-core

@broccolini
Copy link
Copy Markdown
Contributor

Thanks @sophshep 🎉 I've added this to our release backlog for the next major release :)

@jonrohan jonrohan mentioned this pull request Jun 14, 2018
22 tasks
@jonrohan jonrohan changed the base branch from dev to master June 25, 2018 19:41
@shawnbot shawnbot changed the base branch from master to release-11.0.0 October 16, 2018 20:57
Copy link
Copy Markdown
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants