Add note on SCSS' overloaded rgba() function#29
Merged
mdo merged 1 commit intoprimer:masterfrom Apr 15, 2015
Merged
Conversation
Sass + SCSS overrides and overloads the [rgba() function](http://sass-lang.com/documentation/Sass/Script/Functions.html#rgba-instance_method) so it can also take parameters in the format `rgba($color, $alpha)`, e.g. `rgba(#000, .5)`. It'd be pragmatic to leverage that overload and use hex colors that much more consistently in SCSS. If GitHub folks aren't writing much raw CSS this line can be trimmed further, ```* Use hex color codes `#000` (SCSS' `rgba()` function is overloaded to accept hex colors as a param, e.g., `rgba(#000, .5)`).``` (since Sass' overriding of `rgba()` isn't obvious perhaps good to spell it out explicitly here).
Contributor
|
Howdy—thanks for the pull request, @briancs! Before we can merge your changes, we need you to review our Contributor License Agreement (CLA). We think of CLAs as an open source software license between you and the project, letting us and other users know that we have permission to use the code you contribute. At the bottom of the pull request, you'll see the note about a failed test. Just click the Details link, review the CLA, and sign off at the bottom. Questions? Just holler—I'm here to help :). <3 |
mdo
added a commit
that referenced
this pull request
Apr 15, 2015
Add note on SCSS' overloaded rgba() function
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sass + SCSS overrides and overloads the rgba() function so it can also take parameters in the format
rgba($color, $alpha), e.g.rgba(#000, .5).It'd be pragmatic to leverage that overload and use hex colors that much more consistently in SCSS. If GitHub folks aren't writing much raw CSS this line can be trimmed further,
* Use hex color codes#000(SCSS'rgba()function is overloaded to accept hex colors as a param, e.g.,rgba(#000, .5)).(since Sass' overriding ofrgba()isn't obvious perhaps good to spell it out explicitly here).