Move native color styles from the color-modes bundle to the base bundle#2596
Merged
Move native color styles from the color-modes bundle to the base bundle#2596
Conversation
🦋 Changeset detectedLatest commit: 2ae20f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
approved these changes
Mar 29, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
These styles are meant to be browser setup, getting the background color correct and the various selectors for making the native form controls use dark/light.
I discovered that we needed to do this when removing the old color modes from primer_view_components it removed all the background colors. primer/view_components@5c81227 a similar thing happened in https://github.com/primer/react/pull/4352/files?file-filters%5B%5D=.css&file-filters%5B%5D=.js&file-filters%5B%5D=.json&show-deleted-files=true&show-viewed-files=true#diff-269990d48c898cb48f2ec7d9aeb437efe05c0c23aabccfdf079b9993a06ab8bcR9
Can these changes ship as is?
We should check to see if
native.scssis imported in dotcom and update the url accordingly