Make sure to apply backdrops only to one Overlay#2249
Merged
josepmartins merged 5 commits intoprimer:mainfrom Sep 15, 2022
Merged
Make sure to apply backdrops only to one Overlay#2249josepmartins merged 5 commits intoprimer:mainfrom
josepmartins merged 5 commits intoprimer:mainfrom
Conversation
🦋 Changeset detectedLatest commit: da69a14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
approved these changes
Sep 12, 2022
Contributor
langermank
left a comment
langermank
left a comment
There was a problem hiding this comment.
Tested this locally, looks good! We can merge even though the deploy is failing (this is a fork)
josepmartins
approved these changes
Sep 15, 2022
Contributor
|
LGTM! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
I want to make sure backdrop styles are only applied to the correct Overlay. Right now, nested Overlays will inherit their parent overlay styles which makes it impossible to style them correctly.
What approach did you choose and why?
I made sure to use the direct child selector to select the Overlay that a given backdrop should apply to.
What should reviewers focus on?
Is this correct? I just did this quickly and without testing in the GitHub editor.
Can these changes ship as is?