Merged
Conversation
🦋 Changeset detectedLatest commit: 5f10b78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Is there anything I can do to improve this PR and get it shipped? |
simurai
reviewed
May 26, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
fieldsetcan be used to disable all child inputs when it is disabled. Currently,@primer/cssdoes not render.form-controlas disabled when a parentfieldsetis disabled. This PR supports the visual feedback on.form-controlwhen a parent fieldset is disabled.What approach did you choose and why?
I used a local mixin in
form-control.scssto keep the codebase dry and to ensure the disabled style was consistent when applied via.form-control:disabledorfieldset:disabled .form-controlWhat should reviewers focus on?
Reviewers should ensure my local mixin approach is appropriate for readability and code-style.
I noted that the Storybook instance overrides the
fieldsetstyling (from normalize.css) found inform-control.scssand I was unsure what the approach should be to ensure only the@primer/cssstyling wins. I did not want to apply!importantspecificity as there would be drawbacks to that approach.Can these changes ship as is? Yes