Fix unreadable secondary text in dropdown-item on hover/focus#1488
Merged
jonrohan merged 4 commits intoprimer:mainfrom Jul 2, 2021
cheshire137:patch-1
Merged
Fix unreadable secondary text in dropdown-item on hover/focus#1488jonrohan merged 4 commits intoprimer:mainfrom cheshire137:patch-1
jonrohan merged 4 commits intoprimer:mainfrom
cheshire137:patch-1
Conversation
🦋 Changeset detectedLatest commit: 1b917b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
reviewed
Jul 2, 2021
Co-authored-by: Jon Rohan <rohan@github.com>
jonrohan
approved these changes
Jul 2, 2021
Merged
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a change to how
.color-text-*elements within a.dropdown-itemin the hover or focus state appear. Before, the text would appear as dark gray, and thus unreadable on the blue hover background of the dropdown item. With this change, they appear as white, like unstyled text in the dropdown item is on hover./cc @koddsson