[Color Modes] Remove presentational utilities/variables#1233
Merged
simurai merged 3 commits intomkt/color-modes-wheefrom Mar 4, 2021
Merged
[Color Modes] Remove presentational utilities/variables#1233simurai merged 3 commits intomkt/color-modes-wheefrom
simurai merged 3 commits intomkt/color-modes-wheefrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/2Z4LHTGc8ZEfJ8TpvRNCRpG5Qd87 |
Contributor
Author
|
Ok, I tested this in https://github.com/github/github/pull/172506 and seems good. So I'll merge this into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the presentational utilities/variables that got replaced with functional names. See migration guide.
Just a few examples:
.link-gray$border-gray-dark$bg-green$text-blue$box-shadow-medium.box-shadow-extra-large.bg-gray-dark.text-yellow.border-blueEdit: Some of the utilities got added back so that they still work for ViewComponents: 376e0d4