Make brand-orange AA compliant

[amosie]

Brand orange was failing colour contrast checks. As referenced in github/github#40219.

The new orange is now AA complaint and AAA complaint over 18pt.

[jonrohan]

Awesome! 💖

That's really cool, I'd be interested in what tool you used. Also 👍 on the orange

[amosie]

@jonrohan I use http://snook.ca/technical/colour_contrast/colour.html#fg=33FF33,bg=333333 to check contrast and http://contrast-finder.tanaguru.com/result.html?foreground=%23FFFFFF&background=%234183C4&isBackgroundTested=true&ratio=4.5&algo=Rgb to help me find better colours. Although sometimes I have to do that by hand depending how good the results are, but it's a help!

[bleikamp]

It would be helpful to see the color changes in context—could we see some screenshots that show how the colors look as part of the GitHub UI?

[amosie]

@bleikamp for sure, I have posted screen shots for green now too. The orange isn't used in very many places, but where it is used, the proposed change has definitely increased legibility.

Old

New

[nickserv]

👍

[Jastrzebowski]

@amosie definitely better! ++

[mdo]

I'm in favor of this color change for sure. Does this color match our active tab accent on repos @amosie? If it's super close, we can consolidate those values later, too, which would net us a small win, too.

[rands0n]

@amosie totally agree ++ :)