This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Disconnect front end update state from ipc actions and create a new sequelizeManager class#1
Merged
chriddyp merged 8 commits intoplotly:masterfrom May 16, 2016
alexandresobolevski:master
Merged
Disconnect front end update state from ipc actions and create a new sequelizeManager class#1chriddyp merged 8 commits intoplotly:masterfrom alexandresobolevski:master
chriddyp merged 8 commits intoplotly:masterfrom
alexandresobolevski:master
Conversation
| nrows = 1; | ||
| ncols = 1; | ||
| rows = [['command executed']]; | ||
| }else{ |
Member
There was a problem hiding this comment.
let's get eslint going on our machines on monday so that we can have super consistent style. it'll make reading code so much easier
Member
|
once you make those changes, 💃 |
Editor was taking most of the window when the app runs on a laptop. Eases to see the returned rows, metadata etc from the database. Buttons are a bit more fun now. Can edit more the style later.
n-riesco
pushed a commit
that referenced
this pull request
Jul 3, 2018
* Add scheduler * Add sort fns * Move info to props and use defaultProps for mock * Create scheduled query button * Number bug fix * Fix search and sort * Use rowGetter * Use selectors * Remove stage 2 and 3 code * fetch scheduled queries and add to store * Add PropTypes * Fix column resize issue * save all queries in the store and filter by connection in Settings component * Use react-click-outside, preview modal * Create modal factory, lint * Extract Modal, Row, Column components to own files * add SQL syntax highlighting in schedule tab * misc style fixes, add modal close button * add tests for Scheduler, update Scheduler/Modal with fixes found testing * Review Comments #1: - Add comment - Remove old code - Add ms dev * .js extensions * Word wrap SQL preview * Add Layout description comment * Comment react-data-grid formatters * Rename .react.js -> .jsx, import css files * Fix indentation * Better preview header spacing * Bold SQL preview header * Move new deps to devDependencies * Make SchedulerPreview * test/app/components/Settings/Scheduler/Scheduler.test.js -> test/app/components/Settings/scheduler.test.jsx * adapt scheduler test to additional sql element in query modal * Fix scheduler-table styling issues * add className prop type to SQL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: logic to check if sequelizeManaager.initialize exists before accepting and sending a query.