add parseable-enterprise 2.6.7 chart#1625
Conversation
WalkthroughUpdated Helm Changes
Sequence Diagram(s)(Skipped — changes are small refactors and metadata update, not introducing a new multi-component flow.) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3c3e84a
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/query/mod.rs (1)
265-273: Tracing span onQuery::executelooks good.Using
name = "datafusion.execute"withdb.system.name = "datafusion"/db.operation.name = "SELECT"follows the OpenTelemetry database semantic conventions, andskip(self, is_streaming, tenant_id)correctly avoids requiringDebugonQueryand keeps tenant ids out of span fields.One small consideration: since the operation name is hard-coded to
"SELECT", this span will also be emitted for non-SELECT statements that may flow through here (e.g. EXPLAIN, or any future write/DDL path). If that distinction matters for your traces, you could derive it fromself.raw_logical_planinstead — otherwise this is fine as-is.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/query/mod.rs` around lines 265 - 273, The span currently hard-codes db.operation.name = "SELECT" in Query::execute which can mis-label non-SELECT statements; update the tracing attribute to derive the operation name from the Query instance (use self.raw_logical_plan or similar to extract the top-level operation token like "SELECT"/"EXPLAIN"/"INSERT"/"DDL") and set db.operation.name to that derived value so the span accurately reflects the actual statement type (refer to Query::execute and the raw_logical_plan field to locate where to compute and pass the operation name).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/query/mod.rs`:
- Around line 265-273: The span currently hard-codes db.operation.name =
"SELECT" in Query::execute which can mis-label non-SELECT statements; update the
tracing attribute to derive the operation name from the Query instance (use
self.raw_logical_plan or similar to extract the top-level operation token like
"SELECT"/"EXPLAIN"/"INSERT"/"DDL") and set db.operation.name to that derived
value so the span accurately reflects the actual statement type (refer to
Query::execute and the raw_logical_plan field to locate where to compute and
pass the operation name).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 92366e20-cc49-4d70-8e44-382c2c414663
📒 Files selected for processing (6)
src/alerts/alert_structs.rssrc/alerts/mod.rssrc/handlers/http/logstream.rssrc/metrics/prom_utils.rssrc/query/mod.rssrc/query/stream_schema_provider.rs
✅ Files skipped from review due to trivial changes (4)
- src/alerts/alert_structs.rs
- src/alerts/mod.rs
- src/query/stream_schema_provider.rs
- src/metrics/prom_utils.rs
Fixes #XXXX.
Description
This PR has:
Summary by CodeRabbit
New Features
Chores