Skip to content

add parseable-enterprise 2.6.7 chart#1625

Merged
parmesant merged 3 commits into
parseablehq:mainfrom
AdheipSingh:main
Apr 17, 2026
Merged

add parseable-enterprise 2.6.7 chart#1625
parmesant merged 3 commits into
parseablehq:mainfrom
AdheipSingh:main

Conversation

@AdheipSingh
Copy link
Copy Markdown
Member

@AdheipSingh AdheipSingh commented Apr 17, 2026

Fixes #XXXX.

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Summary by CodeRabbit

  • New Features

    • Published parseable-enterprise Helm chart v2.6.7 with updated metadata and packaging.
  • Chores

    • Updated Helm repository index timestamps and chart metadata to reflect latest available versions.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

Walkthrough

Updated Helm index.yaml (timestamps and added parseable-enterprise 2.6.7) and small Rust changes across alert, HTTP logstream, metrics, and query modules: minor refactors, signature/type aliasing, tracing attribute addition, and a couple of formatting/sorting adjustments.

Changes

Cohort / File(s) Summary
Helm Repository Index
index.yaml
Updated top-level generated timestamp; refreshed per-chart created timestamps; added parseable-enterprise v2.6.7 entry with full metadata (dependencies, digest, icon, maintainers, urls).
Alerts
src/alerts/alert_structs.rs, src/alerts/mod.rs
Simplified sorting: replaced explicit sort_by comparator with sort_by_key in get_recovery_times; iteration changed from iter() to values() in list_tags.
HTTP logstream
src/handlers/http/logstream.rs
Removed cast to u64 when reading metric .get() values; metrics assigned directly to Stats fields.
Metrics parsing
src/metrics/prom_utils.rs
Refactored match-arm formatting for sample-pattern handling (compact match arms); no logic changes to accumulation.
Query execution / streaming
src/query/mod.rs, src/query/stream_schema_provider.rs
Introduced internal type aliases (BoxedBatchStream, QueryResult); simplified execute function and method signatures to use QueryResult; added tracing::instrument attribute; minor match-arm formatting in is_overlapping_query. Attention: signature/type changes may affect call sites.

Sequence Diagram(s)

(Skipped — changes are small refactors and metadata update, not introducing a new multi-component flow.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

for next release

Suggested reviewers

  • nitisht
  • nikhilsinhaparseable

Poem

🐰 I hopped through charts with timestamps new,

Pushed a package, tidy and true.
Rust bits polished, signatures neat —
Logs and metrics kept their beat.
A tiny hop, a repo chew — hooray for version two! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is entirely a template with no actual content filled in. All sections remain as placeholders (Fixes #XXXX, Description comments, checklist items all unchecked), providing no meaningful information about the changes or rationale. Replace placeholders with concrete details: describe the goal of adding parseable-enterprise 2.6.7, explain why this version is being added, and confirm testing of log ingestion/query and any documentation updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the primary change: adding parseable-enterprise chart version 2.6.7 to the Helm repository index, which aligns with the index.yaml summary.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

parmesant
parmesant previously approved these changes Apr 17, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 17, 2026
@AdheipSingh AdheipSingh dismissed stale reviews from coderabbitai[bot] and parmesant via 3c3e84a April 17, 2026 04:42
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/query/mod.rs (1)

265-273: Tracing span on Query::execute looks good.

Using name = "datafusion.execute" with db.system.name = "datafusion" / db.operation.name = "SELECT" follows the OpenTelemetry database semantic conventions, and skip(self, is_streaming, tenant_id) correctly avoids requiring Debug on Query and keeps tenant ids out of span fields.

One small consideration: since the operation name is hard-coded to "SELECT", this span will also be emitted for non-SELECT statements that may flow through here (e.g. EXPLAIN, or any future write/DDL path). If that distinction matters for your traces, you could derive it from self.raw_logical_plan instead — otherwise this is fine as-is.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/query/mod.rs` around lines 265 - 273, The span currently hard-codes
db.operation.name = "SELECT" in Query::execute which can mis-label non-SELECT
statements; update the tracing attribute to derive the operation name from the
Query instance (use self.raw_logical_plan or similar to extract the top-level
operation token like "SELECT"/"EXPLAIN"/"INSERT"/"DDL") and set
db.operation.name to that derived value so the span accurately reflects the
actual statement type (refer to Query::execute and the raw_logical_plan field to
locate where to compute and pass the operation name).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/query/mod.rs`:
- Around line 265-273: The span currently hard-codes db.operation.name =
"SELECT" in Query::execute which can mis-label non-SELECT statements; update the
tracing attribute to derive the operation name from the Query instance (use
self.raw_logical_plan or similar to extract the top-level operation token like
"SELECT"/"EXPLAIN"/"INSERT"/"DDL") and set db.operation.name to that derived
value so the span accurately reflects the actual statement type (refer to
Query::execute and the raw_logical_plan field to locate where to compute and
pass the operation name).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 92366e20-cc49-4d70-8e44-382c2c414663

📥 Commits

Reviewing files that changed from the base of the PR and between d35dd05 and 3c3e84a.

📒 Files selected for processing (6)
  • src/alerts/alert_structs.rs
  • src/alerts/mod.rs
  • src/handlers/http/logstream.rs
  • src/metrics/prom_utils.rs
  • src/query/mod.rs
  • src/query/stream_schema_provider.rs
✅ Files skipped from review due to trivial changes (4)
  • src/alerts/alert_structs.rs
  • src/alerts/mod.rs
  • src/query/stream_schema_provider.rs
  • src/metrics/prom_utils.rs

@parmesant parmesant merged commit 5d57a71 into parseablehq:main Apr 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants