test: relocate to utils/json

[de-sh]

Fixes #XXXX.

Description

Relocate test closer to covered function for maintainability

---

This PR has:

• been tested to ensure log ingestion and log query works.
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added documentation for new or modified features or behaviors.

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for JSON processing, ensuring robust error handling and correct flattening of nested structures across different schema versions.
  • Removed outdated test cases to streamline the quality assurance process.

[coderabbitai]

Walkthrough

This pull request removes several test functions and unused imports from the HTTP ingestion handler file while adding new test cases in the JSON utilities module. The new tests in the JSON module check that the function flatten_json_body properly handles both error cases with non-object arrays and correctly processes nested JSON objects with different schema versions (V0 and V1). No public API changes have been made.

Changes

File Path	Change Summary
src/handlers/http/ingest.rs	Removed test functions (non_object_arr_is_err, arr_obj_with_nested_type, arr_obj_with_nested_type_v1) and unused imports from the tests module.
src/utils/json/mod.rs	Added new test cases (non_object_arr_is_err, arr_obj_with_nested_type, arr_obj_with_nested_type_v1) to verify error handling and JSON flattening for schema V0/V1.

Possibly related PRs

• perf: save on clone cost during ingestion #1178: The changes in the main PR involve the removal of test functions related to JSON conversion, while the retrieved PR modifies the convert_to_array function that is directly related to the conversion process, indicating a strong connection at the code level.

Suggested reviewers

• nikhilsinhaparseable

Poem

I'm a rabbit with a joyful leap,
Hoping through tests both shallow and deep.
Old tests bid farewell with a quiet goodbye,
New ones now dance, reaching for the sky.
With code that flattens JSON just right,
I nibble on changes with delight!
Hoppity cheers to progress in sight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2352a4a and 9714a11.

📒 Files selected for processing (1)

• src/handlers/http/ingest.rs (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/handlers/http/ingest.rs

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nikhilsinhaparseable]

good to merge