Skip to content

feat: Ensure expand_implied_roles method resolves the roles#730

Merged
gtema merged 1 commit into
mainfrom
expand_role
May 26, 2026
Merged

feat: Ensure expand_implied_roles method resolves the roles#730
gtema merged 1 commit into
mainfrom
expand_role

Conversation

@gtema
Copy link
Copy Markdown
Collaborator

@gtema gtema commented May 26, 2026

Sometimes it is necessary to get all effective roles knowing only the
list of original role_ids. Update expand_implied_roles method to
lookup for the role information when name attribute is not set (the
name is not nullable in the database, so it is a perfect candidate for
detecting).

Sometimes it is necessary to get all effective roles knowing only the
list of original role_ids. Update `expand_implied_roles` method to
lookup for the role information when `name` attribute is not set (the
name is not nullable in the database, so it is a perfect candidate for
detecting).
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

🦢 Load Test Results

Goose Attack Report

Plan Overview

Action Started Stopped Elapsed Users
Increasing 26-05-26 13:36:29 26-05-26 13:36:31 00:00:02 0 → 4
Maintaining 26-05-26 13:36:31 26-05-26 13:37:01 00:00:30 4
Decreasing 26-05-26 13:37:01 26-05-26 13:37:01 00:00:00 0 ← 4

Request Metrics

Method Name # Requests # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
GET 6637 0 17.58 11 67 221.23 0.00
Aggregated 6637 0 17.58 11 67 221.23 0.00

Response Time Metrics

Method Name 50%ile (ms) 60%ile (ms) 70%ile (ms) 80%ile (ms) 90%ile (ms) 95%ile (ms) 99%ile (ms) 100%ile (ms)
GET 15 19 21 22 23 24 30 67
Aggregated 15 19 21 22 23 24 30 67

Status Code Metrics

Method Name Status Codes
GET 6,637 [200]
Aggregated 6,637 [200]

Transaction Metrics

Transaction # Times Run # Fails Average (ms) Min (ms) Max (ms) RPS Failures/s
ListUsers
0.0 0 0 0.00 0 0 0.00 0.00
0.1 4006 0 14.51 11 44 133.53 0.00
ValidateToken
1.0 0 0 0.00 0 0 0.00 0.00
1.1 2631 0 22.36 15 67 87.70 0.00
Aggregated 6637 0 17.58 11 67 221.23 0.00

Scenario Metrics

Transaction # Users # Times Run Average (ms) Min (ms) Max (ms) Scenarios/s Iterations
ListUsers 2 4004 14.52 11 44 133.47 2002.00
ValidateToken 2 2629 22.36 18 67 87.63 1314.50
Aggregated 4 6633 17.63 11 67 221.10 3316.50

View full report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

🐰 Bencher Report

Branchexpand_role
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
Command_Serde/apply/remove📈 view plot
🚷 view threshold
81,068.00 ns
(-51.99%)Baseline: 168,850.21 ns
659,589.81 ns
(12.29%)
Command_Serde/apply/set📈 view plot
🚷 view threshold
84,303.00 ns
(-40.89%)Baseline: 142,618.46 ns
354,300.34 ns
(23.79%)
Command_Serde/pack/delete📈 view plot
🚷 view threshold
123.94 ns
(+1.20%)Baseline: 122.47 ns
147.69 ns
(83.92%)
Command_Serde/pack/delete_index📈 view plot
🚷 view threshold
116.32 ns
(+1.85%)Baseline: 114.20 ns
136.84 ns
(85.00%)
Command_Serde/pack/set📈 view plot
🚷 view threshold
200.45 ns
(+0.64%)Baseline: 199.17 ns
245.73 ns
(81.57%)
Command_Serde/pack/set_index📈 view plot
🚷 view threshold
116.23 ns
(+1.62%)Baseline: 114.37 ns
136.65 ns
(85.06%)
Command_Serde/unpack/delete📈 view plot
🚷 view threshold
201.11 ns
(+7.90%)Baseline: 186.39 ns
230.42 ns
(87.28%)
Command_Serde/unpack/delete_index📈 view plot
🚷 view threshold
188.42 ns
(+16.18%)Baseline: 162.18 ns
201.79 ns
(93.37%)
Command_Serde/unpack/set📈 view plot
🚷 view threshold
264.93 ns
(+8.87%)Baseline: 243.35 ns
290.00 ns
(91.36%)
Command_Serde/unpack/set_index📈 view plot
🚷 view threshold
187.14 ns
(+16.49%)Baseline: 160.65 ns
200.37 ns
(93.40%)
Payload_encryption/pack/inner📈 view plot
🚷 view threshold
68.47 ns
(+5.55%)Baseline: 64.87 ns
77.87 ns
(87.93%)
Payload_encryption/pack/remove_cmd📈 view plot
🚷 view threshold
121.86 ns
(+0.14%)Baseline: 121.69 ns
148.11 ns
(82.28%)
Payload_encryption/pack/set_cmd📈 view plot
🚷 view threshold
223.37 ns
(-3.88%)Baseline: 232.39 ns
294.13 ns
(75.94%)
Payload_encryption/unpack/inner📈 view plot
🚷 view threshold
165.16 ns
(+1.71%)Baseline: 162.38 ns
193.65 ns
(85.29%)
Payload_encryption/unpack/remove_cmd📈 view plot
🚷 view threshold
208.93 ns
(+6.65%)Baseline: 195.91 ns
241.54 ns
(86.50%)
Payload_encryption/unpack/set_cmd📈 view plot
🚷 view threshold
260.56 ns
(+1.05%)Baseline: 257.86 ns
319.07 ns
(81.66%)
Raft_1Node_Latency/prefix/1node📈 view plot
🚷 view threshold
5,064,800.00 ns
(+44.61%)Baseline: 3,502,319.23 ns
6,561,396.19 ns
(77.19%)
Raft_1Node_Latency/read/1node📈 view plot
🚷 view threshold
598.62 ns
(+8.87%)Baseline: 549.85 ns
772.42 ns
(77.50%)
Raft_1Node_Latency/remove/1node📈 view plot
🚷 view threshold
246,020.00 ns
(-40.85%)Baseline: 415,941.54 ns
1,257,105.90 ns
(19.57%)
Raft_1Node_Latency/write/1node📈 view plot
🚷 view threshold
252,640.00 ns
(-37.20%)Baseline: 402,321.92 ns
992,119.30 ns
(25.46%)
build_snapshot/default📈 view plot
🚷 view threshold
91,181.00 ns
(-3.34%)Baseline: 94,332.67 ns
164,168.88 ns
(55.54%)
fernet token/project📈 view plot
🚷 view threshold
1,550.40 ns
(+5.27%)Baseline: 1,472.73 ns
1,632.17 ns
(94.99%)
get_data_keyspace📈 view plot
🚷 view threshold
0.35 ns
(+11.04%)Baseline: 0.32 ns
0.37 ns
(94.17%)
get_db📈 view plot
🚷 view threshold
0.35 ns
(+11.07%)Baseline: 0.32 ns
0.37 ns
(93.93%)
get_fernet_token_timestamp/project📈 view plot
🚷 view threshold
146.63 ns
(-1.35%)Baseline: 148.64 ns
175.06 ns
(83.76%)
get_keyspace📈 view plot
🚷 view threshold
4.81 ns
(+2.93%)Baseline: 4.68 ns
8.78 ns
(54.82%)
🐰 View full continuous benchmarking report in Bencher

@gtema gtema merged commit 802253c into main May 26, 2026
29 checks passed
@gtema gtema deleted the expand_role branch May 28, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant