SPLAT-2588 / WIP: Removing hypershift gates for AWSServiceLBNetworkSecurityGroup

[mtulio]

No description provided.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@mtulio: This pull request references SPLAT-2588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @mtulio! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mtulio]

/test ?

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 457abdb9-8023-4914-81d2-4d9d31f664e8

📥 Commits

Reviewing files that changed from the base of the PR and between c5a5725 and c12aee7.

📒 Files selected for processing (4)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

📝 Walkthrough

Walkthrough

The PR moves the AWSServiceLBNetworkSecurityGroup feature gate from disabled to enabled in Hypershift Default and OKD FeatureGate manifests and updates features.md to mark those Hypershift columns as Enabled. In features/features.go the feature's enable conditions were changed to enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()). The same file also contains stray numeric literals inserted into a var (...) block (invalid Go syntax).

Possibly related PRs

• openshift/api#2717: Modifies the same AWSServiceLBNetworkSecurityGroup feature gate enablement in features.go and feature-gate YAMLs.

Suggested reviewers

• everettraven
• JoelSpeed

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author, making it impossible to understand the intent and rationale behind the changes.	Add a meaningful pull request description explaining the objective, motivation, and any relevant Jira issue context for reviewers.
Title check	❓ Inconclusive	The title mentions 'Removing hypershift gates' but the code changes show stray numeric literals and syntax errors in Go code that contradict the title's stated intent.	Clarify whether the PR aims to remove Hypershift gates or enable the feature across profiles; address the Go syntax errors (stray numeric literals) to ensure the code compiles successfully.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Test names are all static and deterministic. No dynamic values like pod names, timestamps, UUIDs, node names, namespace names, or IP addresses are used in Ginkgo test titles.
Test Structure And Quality	✅ Passed	The custom check requires reviewing Ginkgo test code for quality. This PR contains no test code changes—only feature gate configuration and documentation modifications. Check not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. Changes are limited to feature gate documentation, definitions, and manifests. The custom check for MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. Changes only affect feature gate documentation and configuration. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies feature gate configurations only, not deployment manifests, operators, or controllers. Feature gates are runtime configuration switches without scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR modifies openshift/api library (API definitions only). No OTE test binary code affected. features.go has zero stdout/logging operations, no main/init/TestMain functions.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The changes are feature gate configuration, documentation, and test infrastructure setup only. The custom check requires new Ginkgo e2e tests to apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@mtulio: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtulio]

/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance

[mtulio]

/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance

[mtulio]

/test e2e-aws-ovn-hypershift-conformance

[mtulio]

/test e2e-aws-ovn-hypershift

[mtulio]

/test all

[mtulio]

/test all

[openshift-ci]

@mtulio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	c12aee7	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.