Skip to content

[DRAFT] generalize OTLP-HTTP exporter#5164

Draft
herin049 wants to merge 1 commit intoopen-telemetry:mainfrom
herin049:feat/otlp-http-general
Draft

[DRAFT] generalize OTLP-HTTP exporter#5164
herin049 wants to merge 1 commit intoopen-telemetry:mainfrom
herin049:feat/otlp-http-general

Conversation

@herin049
Copy link
Copy Markdown
Contributor

@herin049 herin049 commented Apr 30, 2026

Description

Fixes #3439 and #4171

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@DylanRussell
Copy link
Copy Markdown
Contributor

If the only reason for keeping requests.Session around is to keep backward compatability with _OTEL_PYTHON_EXPORTER_OTLP_HTTP_CREDENTIAL_PROVIDER than I think we shouldn't bother..

The Google auth library does have a urllib3 equivalent: https://google-auth.readthedocs.io/en/latest/reference/google.auth.transport.urllib3.html#google.auth.transport.urllib3.AuthorizedHttp -- I think we should just repurpose that env var to return that instead

@DylanRussell
Copy link
Copy Markdown
Contributor

requests.Session was added to the constructor of the HTTP exporter 4 years ago: 0590617 - so maybe we want to keep avoid breaking people that might be passing that in ? IDK

@herin049
Copy link
Copy Markdown
Contributor Author

requests.Session was added to the constructor of the HTTP exporter 4 years ago: 0590617 - so maybe we want to keep avoid breaking people that might be passing that in ? IDK

The idea is that requests.Session is compatible with the protocol so this isn't actually a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept httpx.Client instead of requests.Session

2 participants