Skip to content

Update dependencies list WIP#2612

Merged
MylesBorins merged 5 commits intonodejs:masterfrom
juanarbol:dependencies-update
Oct 14, 2019
Merged

Update dependencies list WIP#2612
MylesBorins merged 5 commits intonodejs:masterfrom
juanarbol:dependencies-update

Conversation

@juanarbol
Copy link
Copy Markdown
Member

http-parser was removed see, I just updated dependencies file

Comment thread locale/en/docs/meta/topics/dependencies.md Outdated
@XhmikosR XhmikosR requested a review from Trott October 9, 2019 08:35
@Trott
Copy link
Copy Markdown
Member

Trott commented Oct 9, 2019

This LGTM but a 👍 from @indutny to make sure we've got it exactly right (especially the removing http-parser part) would be great.

Copy link
Copy Markdown
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants