deps: update V8 to 14.8 by targos · Pull Request #62572 · nodejs/node

targos · 2026-04-03T09:49:13Z

This is not intended to replace #61898, but I'm opening it early so we can hopefully work together to fix it in time for Node.js 26.0.0

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 14.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: nodejs#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools PR-URL: nodejs#56238 Refs: nodejs#55784 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

GCC emits warnings because of the trailing backslashes. PR-URL: nodejs#58070 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

illumos pointers are VA48, can allocate from the top of the 64-bit range as well. PR-URL: nodejs#59805 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

In illumos, madvise(3C) now takes `void *` for its first argument post-illumos#14418, but uses `caddr_t` pre-illumos#14418. This fix will detect if the illumos mman.h file in use is pre-or-post-illumos#14418 so builds can work either way. PR-URL: nodejs#58237 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Original commit message: GCC 15 removed avx10.2-512 target PiperOrigin-RevId: 823560321 Refs: google/highway@989a498 PR-URL: nodejs#60682 Fixes: nodejs#60566 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>

Original commit message: [runtime] always sort transition arrays during rehashing After rehashing, the arrays are no longer in hash-sorted order. In this case, we need to force a re-sort even for small arrays, so that subsequent linear searches can find the correct transition and avoid inserting duplicates. Refs: nodejs#61898 (comment) Change-Id: Ia813d1fb9d23e08012811d672052d235c0e0bf4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7723678 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#106255} Refs: v8/v8@00f6e83

Co-Authored-By: StefanStojanovic <stefan.stojanovic@janeasystems.com>

Refs: v8/v8@51d2067

Add args to `tools/make-v8.sh` for compiling Rust-based components, such as Temporal, for the Linux on ppc64le and s390x V8 CI builds.

Use the method without context parameter; the old API is deprecated. Refs: https://crrev.com/c/7141498

Use the new API which gets a `ModuleCachingCallback` parameter. Refs: https://crrev.com/c/7078551

Refs: nodejs#60616

Refs: v8/v8@16dbed1

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot · 2026-04-03T09:49:22Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

targos · 2026-04-03T09:50:42Z

Build with postmortem support is broken, and 4a0d16e was not enough to fix it, so I disabled it in f1e0d4c to go further. /cc @nodejs/post-mortem

targos · 2026-04-03T09:51:35Z

On macOS, I am currently blocked by this error:

../../deps/v8/src/compiler/turboshaft/operations.h:359:3: note: expanded from macro 'TURBOSHAFT_OTHER_OPERATION_LIST'
  359 |   V(JSStackCheck)                          \
      |   ^~~~~~~~~~~~~~~
../../deps/v8/src/compiler/turboshaft/assembler.h:5604:20: note: expanded from macro 'REDUCE_OP'
 5604 |         const auto location = SourceLocation::Current();                 \
      |                    ^~~~~~~~
../../deps/v8/src/compiler/turboshaft/wasm-shuffle-reducer.cc:576:26: error: no matching member function for call to 'value_or'
  576 |                      max.value_or({}));
      |                      ~~~~^~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/optional:855:46: note: candidate template ignored: couldn't infer template argument '_Up'
  855 |   _LIBCPP_HIDE_FROM_ABI constexpr value_type value_or(_Up&& __v) const& {
      |                                              ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/optional:862:46: note: candidate template ignored: couldn't infer template argument '_Up'
  862 |   _LIBCPP_HIDE_FROM_ABI constexpr value_type value_or(_Up&& __v) && {
      |                                              ^
172 warnings and 1 error generated.

Edit: Copilot suggests this fix. Does it make sense?

diff --git a/deps/v8/src/compiler/turboshaft/wasm-shuffle-reducer.cc b/deps/v8/src/compiler/turboshaft/wasm-shuffle-reducer.cc
index 192af473827..0f8275feded 100644
--- a/deps/v8/src/compiler/turboshaft/wasm-shuffle-reducer.cc
+++ b/deps/v8/src/compiler/turboshaft/wasm-shuffle-reducer.cc
@@ -573,7 +573,7 @@ void WasmShuffleAnalyzer::TryReduceFromMSB(OpIndex input,
     uint8_t index = shuffle.shuffle[i];
     if (index >= lower_limit && index <= upper_limit) {
       max = std::max(static_cast<uint8_t>(index % kSimd128Size),
-                     max.value_or({}));
+                     max.value_or(uint8_t{0}));
     }
   }
   if (max) {

targos · 2026-04-03T10:02:45Z

If I apply the above fix, it fails at node_mksnapshot and I think it's related to v8#245
/cc @joyeecheung

targos · 2026-04-03T10:51:30Z

I don't know how to handle these:

make[2]: *** [libnode.target.mk:548: /home/runner/work/node/node/node/out/Release/obj.target/libnode/src/api/embed_helpers.o] Error 1
In file included from ../src/api/callback.cc:1:
In file included from ../src/async_context_frame.h:6:
In file included from ../src/base_object.h:31:
In file included from ../src/util.h:30:
In file included from ../deps/v8/include/v8.h:33:
In file included from ../deps/v8/include/v8-function.h:15:
../deps/v8/include/v8-template.h:760:12: error: cast from 'NamedPropertySetterCallback' (aka 'Intercepted (*)(Local<Name>, Local<Value>, const PropertyCallbackInfo<void> &)') to 'NamedPropertySetterCallbackV2' (aka 'Intercepted (*)(Local<Name>, Local<Value>, const PropertyCallbackInfo<Boolean> &)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch]
  760 |     return NamedPropertySetterCallbackV2(value);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/include/v8-template.h:772:12: error: cast from 'NamedPropertyDefinerCallback' (aka 'Intercepted (*)(Local<Name>, const PropertyDescriptor &, const PropertyCallbackInfo<void> &)') to 'NamedPropertyDefinerCallbackV2' (aka 'Intercepted (*)(Local<Name>, const PropertyDescriptor &, const PropertyCallbackInfo<Boolean> &)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch]
  772 |     return NamedPropertyDefinerCallbackV2(value);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/include/v8-template.h:887:12: error: cast from 'IndexedPropertySetterCallbackV2' (aka 'v8::Intercepted (*)(unsigned int, Local<Value>, const PropertyCallbackInfo<void> &)') to 'IndexedPropertySetterCallback' (aka 'v8::Intercepted (*)(unsigned int, Local<Value>, const PropertyCallbackInfo<Boolean> &)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch]
  887 |     return IndexedPropertySetterCallback(value);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/v8/include/v8-template.h:899:12: error: cast from 'IndexedPropertyDefinerCallbackV2' (aka 'v8::Intercepted (*)(unsigned int, const v8::PropertyDescriptor &, const PropertyCallbackInfo<void> &)') to 'IndexedPropertyDefinerCallback' (aka 'v8::Intercepted (*)(unsigned int, const v8::PropertyDescriptor &, const PropertyCallbackInfo<Boolean> &)') converts to incompatible function type [-Werror,-Wcast-function-type-mismatch]
  899 |     return IndexedPropertyDefinerCallback(value);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 errors generated.

targos · 2026-04-03T12:09:23Z

Error with GCC:

offsetof  -c ../../deps/v8/src/api/api.cc -o obj/deps/v8/src/api/v8_base_without_compiler.api.o
       > ../../deps/v8/src/api/api.cc: In member function 'bool v8::FunctionTemplate::HasInstance(v8::Local<v8::Value>)':
       > ../../deps/v8/src/api/api.cc:7412:40: error: no matching function for call to 'v8::FunctionTemplate::Cast<v8::internal::JSGlobalProxy>(v8::internal::Tagged<v8::internal::Object>)'
       >  7412 |     auto jsobj = Cast<i::JSGlobalProxy>(*obj);
       >       |                  ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
       > ../../deps/v8/src/api/api.cc:7412:40: note: there is 1 candidate
       > ../../deps/v8/src/api/api.cc:7412:40: note: some candidates omitted; use '-fdiagnostics-all-candidates' to display them

joyeecheung · 2026-04-03T21:37:00Z

I was trying to update to lkgr (14.9.5) in this branch in order to fix canary, I got node_mksnapshot compiled on GCC 13.3 on x64 Linux and then I hit the snapshot issue.

Disabling v8_postmortem_support: I think all consumers of this (in the org, mostly llnode) are no longer maintained. It should be fine to drop it. New plugins should use V8's debug helper library instead.
The wasm-shuffle-reducer.cc fix: yes, that's the right way to fix it.
There are a bunch of unqualified std::nullptr_t, I fixed it in this commit in my branch (not sure if it is not yet in 14.8)
There's a missing include in bigint.h that I fixed in this commit
Some real gyp conditions will be needed to mimic https://chromium-review.googlesource.com/c/v8/v8/+/7683553, I put it in this commit

The snapshot issue is platform independent. I will need to check with the upstream to see what's the path forward (AFAICT, we don't support the configuration where the issue described v8#245 is relevant, maybe we can tweak it differently under the configuration we do build with).

targos · 2026-04-04T06:24:47Z

I already pushed a few fixes that I identified by looking at the GH Actions logs. Feel free to push more and/or upstream some stuff. I'll be away for a week.

targos and others added 26 commits April 3, 2026 10:06

deps: update V8 to 14.8.178.1

26ea541

build: reset embedder string to "-node.0"

d7aa994

src: update NODE_MODULE_VERSION to 147

58a47c1

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 14.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

deps: patch V8 to fix Windows build

9fc31e9

tools: update V8 gypfiles for 14.4

1e704fd

Co-Authored-By: StefanStojanovic <stefan.stojanovic@janeasystems.com>

tools: update V8 gypfiles for 14.5

fb889b4

tools: update V8 gypfiles for 14.6

a147243

Refs: v8/v8@51d2067

tools: update V8 gypfiles for 14.8

96b085f

tools: add Rust args to tools/make-v8.sh

efc83c5

Add args to `tools/make-v8.sh` for compiling Rust-based components, such as Temporal, for the Linux on ppc64le and s390x V8 CI builds.

src: avoid deprecated FixedArray::Get

5fc6a57

Use the method without context parameter; the old API is deprecated. Refs: https://crrev.com/c/7141498

src: avoid deprecated Wasm API

84e5f65

Use the new API which gets a `ModuleCachingCallback` parameter. Refs: https://crrev.com/c/7078551

src: stop using v8::PropertyCallbackInfo<T>::This()

e62e395

Refs: nodejs#60616

src: replace uses of deprecated v8::External APIs

0d1367f

test: add type tags to uses of v8::External

9257df2

test: support presence of Temporal global

06dca55

tools: remove v8_initializers_slow workaround from v8.gyp

0aa2ab3

build: enable V8_VERIFY_WRITE_BARRIERS in debug build

a4290e7

deps: update postmortem metadata generator

4a0d16e

Refs: v8/v8@16dbed1

build: disable postmortem support for now

f1e0d4c

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 3, 2026

targos added 4 commits April 3, 2026 12:13

fixup wasm-shuffle-reducer

501bed1

fixup macros.h

cd9f87a

fixup nullptr_t

1433ef5

fixup nullptr_t 2

c56b103

fixup missing include

beff131

aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: update V8 to 14.8#62572

deps: update V8 to 14.8#62572
targos wants to merge 31 commits intonodejs:mainfrom
targos:v8-148

targos commented Apr 3, 2026

Uh oh!

nodejs-github-bot commented Apr 3, 2026

Uh oh!

targos commented Apr 3, 2026

Uh oh!

targos commented Apr 3, 2026 •

edited

Loading

Uh oh!

targos commented Apr 3, 2026

Uh oh!

targos commented Apr 3, 2026

Uh oh!

targos commented Apr 3, 2026

Uh oh!

joyeecheung commented Apr 3, 2026 •

edited

Loading

Uh oh!

targos commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

targos commented Apr 3, 2026

Uh oh!

nodejs-github-bot commented Apr 3, 2026

Uh oh!

targos commented Apr 3, 2026

Uh oh!

targos commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Apr 3, 2026

Uh oh!

targos commented Apr 3, 2026

Uh oh!

targos commented Apr 3, 2026

Uh oh!

joyeecheung commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

targos commented Apr 3, 2026 •

edited

Loading

joyeecheung commented Apr 3, 2026 •

edited

Loading