parallel/test-http2-misbehaving-multiplex is flaky

[lpinca]

Test

test-http2-misbehaving-multiplex

Platform

Linux x64, macOS x64

Console output

=== release test-http2-misbehaving-multiplex ===
Path: parallel/test-http2-misbehaving-multiplex
node:assert:126
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected "actual" to be strictly unequal to: 5
    at Http2Server.<anonymous> (/home/luigi/node/test/parallel/test-http2-misbehaving-multiplex.js:45:10)
    at Http2Server.<anonymous> (/home/luigi/node/test/common/index.js:488:15)
    at Http2Server.emit (node:events:520:28)
    at ServerHttp2Session.sessionOnStream (node:internal/http2/core:3011:19)
    at ServerHttp2Session.emit (node:events:520:28)
    at emit (node:internal/http2/core:329:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:93:22) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 5,
  expected: 5,
  operator: 'notStrictEqual'
}

Node.js v23.0.0-pre
Command: out/Release/node --expose-internals /home/luigi/node/test/parallel/test-http2-misbehaving-multiplex.js


[01:25|% 100|+ 9999|-   1]: Done

Failed tests:
out/Release/node --expose-internals /home/luigi/node/test/parallel/test-http2-misbehaving-multiplex.js

Build links

Additional information

No response

[lpinca]

The problem is that when client.write(id1.data) is called for the second time

node/test/parallel/test-http2-misbehaving-multiplex.js

Line 77 in 741004a

client.write(id1.data, () => {

the corresponding http2 stream might be fully closed and it seems that in that case no error is raised. Here is a test case that always fails (no error is raised).

'use strict';

const h2 = require('http2');
const net = require('net');
const h2test = require('../common/http2');

const server = h2.createServer();
server.on('stream', function (stream) {
  stream.respond();
  stream.end('ok');
});

server.on('session', function (session) {
  session.on('error', console.error);
});

const settings = new h2test.SettingsFrame();
const settingsAck = new h2test.SettingsFrame(true);
// HeadersFrame(id, payload, padding, END_STREAM)
const id1 = new h2test.HeadersFrame(1, h2test.kFakeRequestHeaders, 0, true);

server.listen(0, () => {
  const client = net.connect(server.address().port, function () {
    client.write(h2test.kClientMagic);
    client.write(settings.data);
    client.write(settingsAck.data);
    client.write(id1.data);
    setTimeout(function () {
      client.write(id1.data)
    }, 100);
  });

  client.on('close', function () {
    server.close();
  });

  client.resume();
});

This seems to be by design. The following callbacks

node/src/node_http2.cc

Lines 517 to 518 in 741004a

	nghttp2_session_callbacks_set_on_invalid_frame_recv_callback(
	callbacks_, OnInvalidFrame);

node/src/node_http2.cc

Line 514 in 741004a

nghttp2_session_callbacks_set_error_callback2(callbacks_, OnNghttpError);

are not called. It just fails silently.