[test] riscv64 failure in parallel/test-crypto-sign-verify

[kapouer]

Version

v18.10.0

Platform

Linux 5.18.0-4-riscv64 #1 SMP Debian 5.18.16-1 (2022-08-10) riscv64 (riscv64)

Subsystem

test

What steps will reproduce the bug?

Run the test.

How often does it reproduce? Is there a required condition?

I don't know. At least once.

What is the expected behavior?

Test succeeds

What do you see instead?

Test fails

Additional information

What do these lines want to achieve exactly ?

node/test/parallel/test-crypto-sign-verify.js

Lines 34 to 47 in ef17711

	const library = {
	configurable: true,
	set() {
	throw new Error('bye, bye, library');
	}
	};
	Object.defineProperty(Object.prototype, 'library', library);
	assert.throws(() => {
	crypto.createSign('sha1').sign(
	`-----BEGIN RSA PRIVATE KEY-----
	AAAAAAAAAAAA
	-----END RSA PRIVATE KEY-----`);
	}, { message: 'bye, bye, library' });

[bnoordhuis]

See #27157 for background. In a nutshell, node shouldn't crash (as in: segfault, abort) when JS code tampers with object prototypes.

[kapouer]

Oh, ok. It's just odd that it's not in its own test.
On the other hand, that test fails on riscv64 - as if the "library" property wasn't changed, and the initial openssl error is caught, not the 'bye, bye, library'.