Problematic string handle

[gengjiawen]

node/src/quic/node_quic_crypto.cc

Line 563 in 5536044

if (alpn == NGTCP2_ALPN_H3 + 1) {

clang warning:

../../src/quic/node_quic_crypto.cc:563:30: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
  if (alpn == NGTCP2_ALPN_H3 + 1) {
              ~~~~~~~~~~~~~~~^~~

cc @jasnell @nodejs/quic

[addaleax]

Right, I’ve run into this as well, but the problem is that the clang warning is just not helpful here. clang suggests using &NGTCP2_ALPN_H3[1] to me, which would probably fix the warning but also look quite a bit more confusing imo.

[jasnell]

The &NGTCP2_ALPN_H3[1] syntax is more confusing but it'll work. Let's just go with that to avoid the compiler warning

[gengjiawen]

Okay, I finally got the original +1 😃 (string + int is pointer arithmetic in C)