Dependency v8 is not Python 3 compatible

[cclauss]

The open bug reports on chromium.org:

• https://bugs.chromium.org/p/v8/issues/detail?id=8594
  • Travis CI: Use flake8 to find Python syntax errors v8/v8#29
• https://bugs.chromium.org/p/chromium/issues/detail?id=914950

@bmsdave commit to upstream: #24512 (comment)

[Trott]

PR has landed so I assume this can be closed. Comment (or re-open if GitHub allows) if I'm wrong about that! Thanks!!!

[refack]

PR has landed so I assume this can be closed.

The files in deps/v8 and tools/inspector_protocol + jinja2 + markupsafe where excluded from #24486. So this is still an issue.

[refack]

/CC @nodejs/v8 @nodejs/v8-inspector

FTR on 1.1.2020 Python 2 hits it's EOL https://pythonclock.org/

[bmsdave]

If you do not mind.
I would like to try to take up this task.
I'll try it this weekend. If I have any problems, I'll write.

[hashseed]

I definitely don't mind any contributions here. Do you have a list of scripts required by Node.js that need to be migrated?

[cclauss]

There are now less that 400 days until the end of life of Python 2 (aka legacy Python). The v8 repo is just 1.4% Python but that is all legacy Python and at least 76 files need to be modified just to fix the print statement which is merely the start of a Python 3 port. v8 is a venerable codebase and I often hear that it has been a godsend to the JavaScript community but its Python code needs to be modernized, removed, or replaced with JavaScript, Go, etc. in the days remain until Python 2 end of life.

I would recommend that someone uses http://python-future.org to do the following:

• Run v8 tests on Python 2.7 and make sure they pass
• Drop commitment to support for all Python versions < 2.7 (they are EOL for 5+ years anyway)
• Run futurize -f libfuturize.fixes.fix_print_with_import -w . at the root of the v8 repo (print() function and new style imports for Python 3 v8/v8#26)
• Run v8 tests on Python 2.7 and make sure they pass
• Run futurize --stage1 -w . at the root of the v8 repo
• Run v8 tests on Python 2.7 and make sure they pass
• Run v8 tests on Python 3.7 in allow_failures mode and fix as you go...

[bmsdave]

Do you have a list of scripts required by Node.js that need to be migrated?

@hashseed I don't have that list. I was planning on finding it through the codebase. But if you provide it, it will be very cool.

@cclauss thank you very much for your clear recommendations. I will try to do it and provide for consideration.

[alexkozy]

@bmsdave any changes to inspector_protocol should be upstreamed to inspector_protocol repo first. I can help you with it as soon as your are ready.