`readDoubleLE` broken on 9.4.0

[arthurschreiber]

• Version: v9.4.0
• Platform: Darwin
• Subsystem: Buffer

It looks like #17775 might have seriously broken Buffer.prototype.readDoubleLE.

On v9.3.0:

Buffer.from([0xeb, 0x97, 0x3a, 0x98, 0x20, 0xdb, 0xc2, 0x40]).readDoubleLE();
// => 9654.254645656756

On v9.4.0:

Buffer.from([0xeb, 0x97, 0x3a, 0x98, 0x20, 0xdb, 0xc2, 0x40]).readDoubleLE();
// => -5.828774743119337e-192

[BridgeAR]

Hm, this is going to be fixed on master in #18395.

I am going to open a backport of that PR without any semver-major changes that will also fix that problem.

[ChALkeR]

It looks like only the version without the offset parameter is broken?

> Buffer.from([0xeb, 0x97, 0x3a, 0x98, 0x20, 0xdb, 0xc2, 0x40]).readDoubleLE(0);
9654.254645656756
> Buffer.from([0xeb, 0x97, 0x3a, 0x98, 0x20, 0xdb, 0xc2, 0x40]).readDoubleLE();
-5.828774743119337e-192

The bad thing is that there are currently no tests for the offset-less versions of those functions.

[BridgeAR]

@ChALkeR you are right and that got already fixed by #18215.

[BridgeAR]

@arthurschreiber the next minor is going to contain that fix. Nevertheless it is recommended to always explicitly pass the offset. It is not meant as optional argument.