url: errounous hash appended on url.format

[silverwind]

This is breaking npm installs and should be fixed before 2.0.0.

Encountered in https://github.com/npm/normalize-git-url/blob/master/normalize-git-url.js

1.8.1

> parsed = url.parse("git+ssh://git@github.com:organization/repo.git#hashbrowns")
> parsed.hash = ''
> url.format(parsed)
'git+ssh://git@github.com/:organization/repo.git'

2.0.0

> parsed = url.parse("git+ssh://git@github.com:organization/repo.git#hashbrowns")
> parsed.hash = ''
> url.format(parsed)
> 'git+ssh://git@github.com/:organization/repo.git#'

cc: @petkaantonov @domenic @rvagg

[petkaantonov]

Yea ill fix this in a minute

[domenic]

Is this a bug or is it how browsers behave? Shouldn't you be setting hash to null if you want no hash?

[targos]

On Chrome:

[silverwind]

So this is correct behaviour. location.hash = null also removes the #. I think for a proper fix, we need to get an npm update, I'll open a PR on that repo.

[targos]

Also I do not know how to remove the trailing "#" once it is there.
location.hash = null transforms it to "#null"

[silverwind]

location.hash = null transforms it to "#null"

I'm not seeing this. What are your steps?

[indutny]

I see it too.

[domenic]

This behavior seems to vary per browser. We can check the spec but given that we should maybe pick the most compatible choice for 2.0.0 (i.e. .hash = "" removes the hash) and for 3.0.0 either match the spec or get the spec changed.

[silverwind]

location.hash = null does transform it to #null in my browser (Firefox), but removes the hash completely (including '#') in both io.js 1.8.1 and 2.0.0.

[silverwind]

I think @domenic's suggestion to restore old behaviour is probably the way to go in that case, giving that the null thing isn't conforming either.