Bot failed to label PR

[mscdex]

nodejs/node#9171

Not sure why it didn't label it as stream.

[mscdex]

Another instance tonight: nodejs/node#9173

[phillipj]

I'm probably the one to blame after merging a label related PR yesterday.

Had a quick look in the logs, no errors found, and it did get the "PR opened"-event from GitHub on both PRs. Doing more verbose logging would be good for easier debugging

[mscdex]

Possibly another instance FWIW: nodejs/node#9178

[mscdex]

Another: nodejs/node#9187

Should I stop posting examples?

[phillipj]

Yepp, thanks! I'll dig into this tonight, and keep you updated.

On Wednesday, 19 October 2016, Brian White notifications@github.com wrote:

Another: nodejs/node#9187 nodejs/node#9187

Should I stop posting examples?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#86 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLLE7I0KnhdpxL7lezYZwrhj5NpD_Rtks5q1i-ygaJpZM4KaTjP
.

[phillipj]

🎉 nodejs/node#9191

Just found a possible corner case which haven't been fixed tho. Sadly the github client lib we're using only allows us to fetch 100 repository labels with one single call to .getLabels(). As the node repo currently has 117 repo labels in total, there's a chance we won't add some resolved labels as we consider those 17 labels not to exist in the repo, and therefore won't add them to PRs either.

Will have a look at improving that later.

[mikeal]

Maybe we should just pair down to less that 100 labels :)