Add email with IMAP backend#263
Closed
brknkfr wants to merge 13 commits intonextcloud:masterfrom
Closed
Conversation
brknkfr
force-pushed
the
add_email_address
branch
from
5084407 to
ccaea55
Compare
CarlSchwan
reviewed
Oct 16, 2025
Signed-off-by: Sebastian L. <sl@momou.ch>
Make the app compatible with Nextcloud 30 Signed-off-by: Ralf <ervee@moskovic.org> Signed-off-by: Sebastian L. <sl@momou.ch>
Signed-off-by: Anna <anna@nextcloud.com> Signed-off-by: Sebastian L. <sl@momou.ch>
Signed-off-by: Holger Schletz <holger.schletz@web.de> Signed-off-by: Sebastian L. <sl@momou.ch>
- Bump version to 3.6.0, set NC compatibility to min=31 max=32 - Replace deprecated OC::$server service locators with constructor-injected IDBConnection, IUserManager, IGroupManager (optional params for BC) - Replace $query->execute() with executeQuery()/executeStatement() and fetchColumn() with fetchOne() (NC32 DB API changes) - Add resolveUid() to Base: maps email login names back to stored uids for NC32 email-to-uid resolution; call it in all checkPassword() impls - Remove dead old tests (wrong class names, removed NC APIs, never ran) - Add PHPUnit 11 test infrastructure via vendor-bin pattern - Add 19 unit tests for Base with mocks (tests/unit/BaseTest.php) - Add 14 integration tests against live NC DB (tests/integration/) - Align bootstrap, phpunit.xml and composer scripts with NC app conventions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Sebastian L. <sl@momou.ch>
Each workflow uses the nextcloud-version-matrix action to test against all supported NC/PHP version combinations, runs both unit and integration test suites via composer scripts, and includes a path-filter to skip unchanged code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Sebastian L. <sl@momou.ch>
Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Sebastian L. <sl@momou.ch>
Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Sebastian L. <sl@momou.ch>
AI-assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Sebastian L. <sl@momou.ch>
Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Sebastian L. <sl@momou.ch>
Implements the feature requested in PR nextcloud#225 / proposed in PR nextcloud#227. Adds an optional second constructor argument ('basic' or 'digest', defaulting to 'basic' for full backward compatibility). AI-assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Sebastian L. <sl@momou.ch>
Move mbstrtolower for $email Use filter_var to check for valid email Signed-off-by: Sebastian L. <sl@momou.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
Changes proposed in this pull request:
uidvariable contains the @ symbol it gets stored into the variableemailwhich is set automatically for the specific user