fix(core): provide valid initial state also on public templates#59952
Merged
fix(core): provide valid initial state also on public templates#59952
Conversation
The `core apps` initial state should be an array of apps currently available. But for public templates when there is no navigation entry the array would contain `[null]` instead of `[]` which breaks some use cases (e.g. apps that rely on some nextcloud-vue versions). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
ArtificialOwl,
come-nc,
leftybournes and
sorbaugh
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
come-nc
approved these changes
Apr 28, 2026
skjnldsv
approved these changes
Apr 30, 2026
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
Ref: #59639 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
core appsinitial state should be an array of apps currently available. But for public templates when there is no navigation entry the array would contain[null]instead of[]which breaks some use cases (e.g. apps that rely on some nextcloud-vue versions).Checklist
3. to review, feature component)stable32)AI (if applicable)