Skip to content

[stable31] fix: Add missing PasswordConfirmationRequired attributes#59812

Merged
sorbaugh merged 5 commits intostable31from
backport/59788/stable31
Apr 27, 2026
Merged

[stable31] fix: Add missing PasswordConfirmationRequired attributes#59812
sorbaugh merged 5 commits intostable31from
backport/59788/stable31

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented Apr 21, 2026

Backport of #59788

@backportbot backportbot Bot requested review from come-nc, susnux and szaimen April 21, 2026 19:16
@backportbot backportbot Bot added the 3. to review Waiting for reviews label Apr 21, 2026
@backportbot backportbot Bot self-assigned this Apr 21, 2026
@github-actions github-actions Bot changed the title [stable31] [stable32] fix: Add missing PasswordConfirmationRequired attributes [stable31] fix: Add missing PasswordConfirmationRequired attributes Apr 21, 2026
Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

come-nc and others added 4 commits April 23, 2026 11:25
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
chore(cypress): Add handling for added password confirmation dialog

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

[skip ci]
…ctions

Register axios password confirmation interceptors in the apps
management, admin delegation, admin security, and OAuth2 settings
bundles, and pass PwdConfirmationMode.Strict on requests to endpoints
protected with #[PasswordConfirmationRequired(strict: true)], so that
the user password is verified via Basic auth on the request itself
rather than relying on the session timestamp.

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the backport/59788/stable31 branch from 4ff621f to 8527776 Compare April 23, 2026 09:30
@come-nc
Copy link
Copy Markdown
Contributor

come-nc commented Apr 23, 2026

/compile /

@come-nc come-nc marked this pull request as ready for review April 23, 2026 09:30
@come-nc come-nc requested a review from provokateurin as a code owner April 23, 2026 09:30
Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@come-nc
Copy link
Copy Markdown
Contributor

come-nc commented Apr 23, 2026

/backport! to stable30

@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 27, 2026
@come-nc
Copy link
Copy Markdown
Contributor

come-nc commented Apr 27, 2026

CI failure is unrelated

@come-nc come-nc self-assigned this Apr 27, 2026
@sorbaugh sorbaugh merged commit 4ffb28d into stable31 Apr 27, 2026
205 of 218 checks passed
@sorbaugh sorbaugh deleted the backport/59788/stable31 branch April 27, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants