fix(files): remove error message when closing the "Open locally" dialog#59647
fix(files): remove error message when closing the "Open locally" dialog#59647
Conversation
DmySyz
force-pushed
the
fix/open-locally-error-message
branch
2 times, most recently
from
b46a355 to
4628066
Compare
|
/compile rebase |
DmySyz
force-pushed
the
fix/open-locally-error-message
branch
3 times, most recently
from
240f5f4 to
b46a355
Compare
catch the exception thrown by the "open locally" dialog when closed within the action itself, so that it does not produce an error message when caught by higher level logic Signed-off-by: dsyzov <sizovdmitrij@gmail.com>
Signed-off-by: dsyzov <sizovdmitrij@gmail.com>
DmySyz
force-pushed
the
fix/open-locally-error-message
branch
from
b46a355 to
f163f79
Compare
|
/compile rebase |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport to stable33 |
|
/backport to stable32 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
Summary
Catch the exception thrown by the "open locally" dialog when closed within the action itself, so that it does not produce an error message when caught by higher level logic.
Why
The "Open locally" dialog shows up after the action has taken place - offering to retry or open online. It is shown regardless of the first attempts result as it cannot be detected.
However if the file was opened successfully and the user closes the popup - an error message is shown due to the fact that the dialog component throws an error when closed. This is confusing for the users.
Checklist
3. to review, feature component)stable32)AI (if applicable)