fix: folder tree selection after any action in main content by mykh-hailo · Pull Request #59359 · nextcloud/server

mykh-hailo · 2026-03-31T17:06:37Z

Resolves: Folder tree view: Selected folder in left sidebar is deselected after any action in main window, causing loss of user context #59171

Summary

his PR improves UI behavior and layout consistency in file navigation.
It fixes incorrect selection behavior in the Files left sidebar for folder-tree entries.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

skjnldsv · 2026-04-01T06:37:14Z

+const isFolderTreeNode = computed(() => props.view.id.startsWith(`${folderTreeId}::`))
+const isDirectoryActive = computed(() => {
+	if (!isFolderTreeNode.value) {
+		return false
+	}
+
+	const currentView = String(route.params?.view ?? '')
+	const currentDir = normalizeDir(route.query?.dir)
+	const viewDir = normalizeDir(props.view.params?.dir)
+
+	return currentView === folderTreeId && currentDir === viewDir
+})


Can't really say I'm happy to see custom view code into a global component, but I don't really see a better way, that's correct yeah 🤔

@susnux , any opinions ?

Seems like a router issue / design problem.
Because the URL is bound to active file not active folder (/files/ACTIVEFILE?dir=ACTIVEFOLDER vs /files/ACTIVEFOLDER?file=ACTIVEFILE)

So this happens because we se the to of the view to /files/FOLDERID right?
Does it work if we instead just use "additional params" and use the dir param?

@susnux I update some codes to make tree view selection works properly as expected.
For a technical overview, I have the FolderNavigationListItem to be active according to dir parameter of the route.
I'd appreciate it if you review and share any opinion on it.

mykh-hailo · 2026-04-07T13:38:51Z

@susnux I updated the code with the latest master branch.
I'd appreciate it if you check it please.

mykh-hailo · 2026-04-08T06:47:20Z

@susnux , @skjnldsv
I'd appreciate it if you provide any updates on this PR.

mykh-hailo · 2026-04-09T13:42:23Z

@skjnldsv , @susnux , @sorbaugh , @nfebe
Could you provide me any updates on this PR please?

mykh-hailo · 2026-04-13T06:08:27Z

@artonge I'd appreciate it if you have any change to review this PR and leaves some feedback.

cc @susnux , @skjnldsv , @sorbaugh , @nfebe

github-actions · 2026-04-15T02:14:25Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

mykh-hailo · 2026-04-16T07:00:50Z

@susnux , @artonge , @szaimen
Can you help me to merge this PR asap?

szaimen · 2026-04-16T09:20:20Z

@susnux , @artonge , @szaimen Can you help me to merge this PR asap?

Sorry, I cannot judge this part of the code.

susnux

I do not think we should pull in any logic specific to some views into this component.
Views should define what they need and the files app should just display them without knowledge of the internals of any view.

That we already have pulled in foldertree here is a pity and we should fix that properly.

For this problem here I think the proper solution is to find the really active view and not rely on the navigation component. Meaning we should in the navigation component calculate the active view entry and then manually set it as active.

Something like this (and then pass it down to the navigation list items):

// in files navigation
const allViews = useViews()
const route = useRoute()
const currentViewId = computed(() => route?.params?.view || 'files')
// new code
const currentActiveNavigation = computed(() => {
    // all views matching current id (either by their id or their navigation params)
    const views = allViews.value.filter((view) => view.id === currentViewId.value || view.params?.view === currentViewId.value)
    // all views that have not only view id matching but also all of their params
    const matchingParams = views.filter((view) => view.params
        && Object.entries(view.params).every(([key, value]) => {
            if (key in route.params) {
                return route.params[key] === value
            }
            return route.query[key] === value
        }))
        // ensure that the one with most params is the first (most specific route)
        .sort((a, b) => Object.keys(b.params!).length - Object.keys(a.params!).length)
    return matchingParams[0] ?? views[0]!
})

mykh-hailo · 2026-04-24T16:05:56Z

@susnux I updated the code for you comment.
I'd appreciate it if you leave any comments on this.

mykh-hailo · 2026-04-27T02:20:16Z

@susnux , Can you check this PR please?

mykh-hailo · 2026-04-29T14:13:33Z

@susnux I'd appreciate it if you can review this PR.

susnux · 2026-04-29T15:14:55Z

+const currentNavigationView = computed(() => {
+	const routeDir = typeof route.query?.dir === 'string' ? route.query.dir : undefined
+	if (routeDir) {
+		const matchingView = allViews.value.find((view) => typeof view.params?.dir === 'string' && isSamePath(view.params.dir, routeDir))
+		if (matchingView) {
+			return matchingView.id
+		}
+		return undefined
+	}
+
+	return route?.params?.view || 'files'
+})


There could be multiple matches so we need to find the best match:

Suggested change

const currentNavigationView = computed(() => {

const routeDir = typeof route.query?.dir === 'string' ? route.query.dir : undefined

if (routeDir) {

const matchingView = allViews.value.find((view) => typeof view.params?.dir === 'string' && isSamePath(view.params.dir, routeDir))

if (matchingView) {

return matchingView.id

}

return undefined

}

return route?.params?.view || 'files'

})

const currentNavigationView = computed(() => {

const views = allViews.value.filter((view) => view.id === currentViewId.value

|| view.params?.view === currentViewId.value)

const matchingParams = views.filter((view) => view.params

&& Object.entries(view.params).every(([key, value]) => {

if (key in route.params) {

return route.params[key] === value

}

return route.query[key] === value

}))

.sort((a, b) => Object.keys(b.params!).length - Object.keys(a.params!).length)

// if we have a full match use that

if (matchingParams.length > 0) {

return matchingParams[0]

}

// otherwise check if at least view + dir matches

const matchingDir = views.find((view) => view.params?.dir === route.query.dir)

if (matchingDir) {

return matchingDir

}

// finally fallback to the parent view

return views.find((view) => view.id === currentViewId.value)!

})

susnux

Testing this showed that there are some cases where multiple views match - but its only possible for one view to be active.
So the logic needs to be extended a bit.

Also while passing this down using props is ok, it might be cleaner to just use provide and inject instead?

mykh-hailo · 2026-04-30T17:42:35Z

@susnux , I updated the code for your comment, I 'd appreciate it if you have time to review it again.
Thank you.

mykh-hailo · 2026-05-01T15:23:22Z

@susnux can you review this PR please?

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>

mykh-hailo · 2026-05-04T05:26:13Z

@susnux can you review this PR please?

mykh-hailo requested review from a team and skjnldsv as code owners March 31, 2026 17:06

mykh-hailo requested review from nfebe and sorbaugh and removed request for a team March 31, 2026 17:06

skjnldsv reviewed Apr 1, 2026

View reviewed changes

skjnldsv requested a review from susnux April 1, 2026 06:37

skjnldsv added bug 3. to review Waiting for reviews feature: files labels Apr 1, 2026

skjnldsv added this to the Nextcloud 34 milestone Apr 1, 2026

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 86139a8 to 8306091 Compare April 6, 2026 04:34

susnux added the team: Files Code maintained by 📁 Files team label Apr 6, 2026

mykh-hailo force-pushed the fix/folder-tree-view-selection branch 2 times, most recently from 8e5c85f to a7172a3 Compare April 7, 2026 13:38

mykh-hailo force-pushed the fix/folder-tree-view-selection branch 3 times, most recently from aaf8ec9 to f7243b8 Compare April 7, 2026 16:03

mykh-hailo force-pushed the fix/folder-tree-view-selection branch 2 times, most recently from a43ee10 to be24676 Compare April 9, 2026 09:38

mykh-hailo requested a review from skjnldsv April 9, 2026 10:00

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from be24676 to 69fe46e Compare April 9, 2026 14:03

mykh-hailo mentioned this pull request Apr 9, 2026

feat: remove password column from user table #59348

Merged

7 tasks

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 69fe46e to 7cc4c09 Compare April 13, 2026 06:07

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 7cc4c09 to 339d4f9 Compare April 13, 2026 19:49

github-actions Bot added the feedback-requested label Apr 15, 2026

susnux reviewed Apr 16, 2026

View reviewed changes

mykh-hailo force-pushed the fix/folder-tree-view-selection branch 2 times, most recently from 14d8201 to ce67cec Compare April 24, 2026 16:05

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from ce67cec to 9dd4501 Compare April 27, 2026 01:40

mykh-hailo closed this Apr 27, 2026

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 9dd4501 to dfa407c Compare April 27, 2026 13:09

mykh-hailo reopened this Apr 27, 2026

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from 14d8201 to f95e60b Compare April 29, 2026 14:13

susnux reviewed Apr 29, 2026

View reviewed changes

mykh-hailo force-pushed the fix/folder-tree-view-selection branch 2 times, most recently from 11ff813 to ad4f750 Compare April 30, 2026 17:41

fix: folder tree selection after any action in main content

f1b4dc7

Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>

mykh-hailo force-pushed the fix/folder-tree-view-selection branch from ad4f750 to f1b4dc7 Compare May 1, 2026 17:02

mykh-hailo requested a review from susnux May 4, 2026 05:18

Uh oh!

Conversation

mykh-hailo commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

AI (if applicable)

Uh oh!

skjnldsv Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

skjnldsv Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

susnux Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

mykh-hailo Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented Apr 7, 2026

Uh oh!

mykh-hailo commented Apr 8, 2026

Uh oh!

mykh-hailo commented Apr 9, 2026

Uh oh!

mykh-hailo commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

mykh-hailo commented Apr 16, 2026

Uh oh!

szaimen commented Apr 16, 2026

Uh oh!

susnux left a comment

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented Apr 24, 2026

Uh oh!

mykh-hailo commented Apr 27, 2026

Uh oh!

mykh-hailo commented Apr 29, 2026

Uh oh!

susnux Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

susnux left a comment

Choose a reason for hiding this comment

Uh oh!

mykh-hailo commented Apr 30, 2026

Uh oh!

mykh-hailo commented May 1, 2026

Uh oh!

mykh-hailo commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mykh-hailo commented Mar 31, 2026 •

edited

Loading

mykh-hailo Apr 6, 2026 •

edited

Loading

mykh-hailo commented Apr 13, 2026 •

edited

Loading