fix(dav): AddExtraHeadersPlugin should not be handled on error#59344
Merged
fix(dav): AddExtraHeadersPlugin should not be handled on error#59344
AddExtraHeadersPlugin should not be handled on error#59344Conversation
When a request failed (failed upload) the file is not created, thus this will spam the log with "cannot set extra headers" error. To reproduce use e.g. files_antivirus with eicar test files. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
Altahrim,
ArtificialOwl,
CarlSchwan and
salmart-dev
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
marcoambrosini
approved these changes
Apr 10, 2026
CarlSchwan
approved these changes
Apr 10, 2026
szaimen
approved these changes
Apr 13, 2026
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/59344/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f4151eb0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/59344/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Contributor
Author
|
Ah the feature is 34+ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a request failed (failed upload) the file is not created, thus this will spam the log with "cannot set extra headers" error. To reproduce use e.g. files_antivirus with eicar test files.
Checklist
3. to review, feature component)stable32)AI (if applicable)