ci: stop running lint in lint-php-cs unconditionally even if no changes#59318
Merged
nickvergessen merged 1 commit intomasterfrom Mar 31, 2026
Merged
ci: stop running lint in lint-php-cs unconditionally even if no changes#59318nickvergessen merged 1 commit intomasterfrom
lint in lint-php-cs unconditionally even if no changes#59318nickvergessen merged 1 commit intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
CarlSchwan,
leftybournes and
salmart-dev
and removed request for
a team
joshtrichards
changed the title
lint in lint-php-cs unconditionally even if no changes
nickvergessen
approved these changes
Mar 30, 2026
Contributor
|
This is a shared workflow, does it also needs fixing in https://github.com/nextcloud/.github ? |
susnux
approved these changes
Mar 31, 2026
Member
Author
Probably, but the shared one doesn't even have the |
Member
|
linting in most apps takes < 1s, so the additional queuing of changed + summary would cause more CI time waste |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This workflow already runs
changesand properly handles thelintresult in the summary. However it did not have a conditional on thelintrun itself, so it always runs lint (even when there are no relevant changes).TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)