Skip to content

chore(EventSource): drop no longer needed legacy fallback#59141

Merged
susnux merged 5 commits intomasterfrom
jtr/chore-EventSource-drop-legacy-IE-inline-fallback
Mar 21, 2026
Merged

chore(EventSource): drop no longer needed legacy fallback#59141
susnux merged 5 commits intomasterfrom
jtr/chore-EventSource-drop-legacy-IE-inline-fallback

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

@joshtrichards joshtrichards commented Mar 21, 2026

  • Resolves: #

Summary

The OC\EventSource class has a legacy iframe-based fallback (dating back to ownCloud/IE9 era).

The workaround was needed back in 2015 because older Microsoft browsers were in an awkward in-between state:

  • They began enforcing Content Security Policy (CSP) restrictions.
  • But they still lacked proper EventSource (Server-Sent Events) support.

However:

  • The EventSource API has been supported in all browsers since IE was retired (Chrome 6+, Firefox 6+, Safari 5+, Edge 12+)
  • Nextcloud's own browser support requirements have long excluded IE
  • The only consumer is the updater (UpdaterAdmin.vue -> new OCEventSource(...)) which will work identically with native SSE
  • The useFallBack property defaults to false, so on any modern browser the fallback was already never triggered

TODO

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added technical debt 🧱 🤔🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Mar 21, 2026
@joshtrichards
Copy link
Copy Markdown
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Mar 21, 2026
@joshtrichards joshtrichards marked this pull request as ready for review March 21, 2026 17:04
@joshtrichards joshtrichards requested review from a team as code owners March 21, 2026 17:04
@joshtrichards joshtrichards requested review from ArtificialOwl, icewind1991, nfebe, salmart-dev, susnux and szaimen and removed request for a team March 21, 2026 17:04
@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Mar 21, 2026
Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! Thank you very much.

Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux merged commit 9d8bab0 into master Mar 21, 2026
189 of 191 checks passed
@susnux susnux deleted the jtr/chore-EventSource-drop-legacy-IE-inline-fallback branch March 21, 2026 21:47
@nextcloud-bot nextcloud-bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants