Remove usage of static vars or properties#59002
Draft
Conversation
Contributor
Author
No idea how to explain to psalm that this is fine 🤷 |
come-nc
commented
Mar 17, 2026
come-nc
commented
Mar 17, 2026
| static $eventSent = false; | ||
| if (!$eventSent) { | ||
| private function callForRegistrations(): void { | ||
| if (!$this->eventSent) { |
Contributor
Author
There was a problem hiding this comment.
This fails in tests because the listener gets the singleton from container and tries to re-register the backend.
It can only happen if code creates BackendService objects.
Not sure how to best fix it.
Ideally we should move to a typed event with a pointer to the backend service. But that cannot be done right away.
Maybe we should get the singleton from container and check eventSent on it?
7 tasks
4620c0f to
91ba91a
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Support was added in PHP 8.3 and we need to support 8.2 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
139ae8a to
068218c
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
It’s not easy to remove this one but at least make it visible Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
The behaviour of getAppNameFromPath is really different from what was mocked, so I’m not sure whether the class behaves as initially intended. I adapted the test to match the class behavior for now. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
There is only one instance so caching in a property is enough. There were two levels of caching, removed one. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
It’s actually more correct to cache this per-instance. What’s less clear is whether this can always fit in memory. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…er_ldap Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…aces Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
068218c to
2a29e8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Static properties, and even worse static vars in methods are hard to reset from outside, and become a major problem when wanting to make use of the worker mode of FrankenPHP or any similar project.
So this PR removes such declarations and adds a psalm custom plugin to forbid their use.
Checklist
3. to review, feature component)stable32)AI (if applicable)