feat(recent-files): allow configuring image grouping#58908
Conversation
a9c6f99 to
8a2e1da
Compare
|
/compile |
a9b23e1 to
f08a1c9
Compare
f08a1c9 to
11b45bf
Compare
1da5753 to
e872416
Compare
|
Has this been approved by @nextcloud/designers ? |
susnux
left a comment
There was a problem hiding this comment.
blocking for two reasons:
- This is completely changing the UI/UX and should go through feature planning / @nextcloud/designers review
- Have you properly checked virtual scrolling? What happens if you extend them and then scroll down over the scroll order? Because now one item is no longer a fixed height and that can likely break all of the virtual scrolling
a15e53f to
fed387c
Compare
…ce level Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
fed387c to
8f2cfe5
Compare
|
Quick update on the state of this PR:
|
Dismissing this review since the PR now focuses on the backend only and the previous review was about the frontend implementation. Anyway, thanks for taking the time to review!
|
/backport to stable33 |
|
/backport to stable32 |
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
Holding off on merging for now, we still have some internal discussion going on regarding this PR. |
|
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/58908/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a9676604 d63f3e97 c286b826 d363057a ba267686 8f2cfe5f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58908/stable29Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/58908/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a9676604 d63f3e97 c286b826 d363057a ba267686 8f2cfe5f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58908/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/58908/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a9676604 d63f3e97 c286b826 d363057a ba267686 8f2cfe5f
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58908/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
@cristianscheid after discussion with @sorbaugh, the API is fine, so I merged this PR. The backports will be tricky as the lexicon was introduced in 31 only, so they will need some adjustments. |
Summary
This PR focuses on the backend part of implementation.
group_recent_filesrecent_files_group_mime_typesrecent_files_group_timespan_minutesCan be set using occ command (examples below):
occ config:app:set files group_recent_files --value=true occ config:app:set files recent_files_group_mime_types --value='["image/avif","image/gif","image/heic","image/heif","image/jpeg","image/jpg","image/jxl","image/png","image/tiff","image/webp"]' occ config:app:set files recent_files_group_timespan_minutes --value=5Checklist
3. to review, feature component)stable32)AI (if applicable)