Skip to content

fix(dav): add missing search_supports_creation_time and search_supports_upload_time to Capabilities return type#58699

Merged
miaulalala merged 1 commit intomasterfrom
fix/noid/dav-capabilities-psalm-return-type
Mar 3, 2026
Merged

fix(dav): add missing search_supports_creation_time and search_supports_upload_time to Capabilities return type#58699
miaulalala merged 1 commit intomasterfrom
fix/noid/dav-capabilities-psalm-return-type

Conversation

@cristianscheid
Copy link
Copy Markdown
Contributor

@cristianscheid cristianscheid commented Mar 3, 2026

  • Resolves: #

Summary

Fix psalm error by adding missing search_supports_creation_time and search_supports_upload_time to Capabilities return type

Follow-up to #58562

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@cristianscheid cristianscheid requested a review from a team as a code owner March 3, 2026 17:07
@cristianscheid cristianscheid requested review from Altahrim, artonge, nfebe and salmart-dev and removed request for a team March 3, 2026 17:07
@cristianscheid cristianscheid force-pushed the fix/noid/dav-capabilities-psalm-return-type branch from 31fc148 to 29d98bc Compare March 3, 2026 17:17
@cristianscheid cristianscheid force-pushed the fix/noid/dav-capabilities-psalm-return-type branch 2 times, most recently from dcf5d04 to 1267e31 Compare March 3, 2026 17:54
…ts_upload_time to Capabilities return type

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid cristianscheid force-pushed the fix/noid/dav-capabilities-psalm-return-type branch from 1267e31 to 80184b4 Compare March 3, 2026 18:01
@joshtrichards joshtrichards added tests Related to tests 3. to review Waiting for reviews labels Mar 3, 2026
Copy link
Copy Markdown
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need backporting too, at least if the failed backports on #58562 are dealt with. ;-)

@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Mar 3, 2026
@cristianscheid cristianscheid enabled auto-merge March 3, 2026 18:25
@cristianscheid cristianscheid self-assigned this Mar 3, 2026
@cristianscheid cristianscheid disabled auto-merge March 3, 2026 19:05
@cristianscheid
Copy link
Copy Markdown
Contributor Author

This will need backporting too, at least if the failed backports on #58562 are dealt with. ;-)

@joshtrichards For stable33 this backport should fix it: #58694. I've adjusted it to avoid the psalm errors.

@miaulalala miaulalala enabled auto-merge March 3, 2026 19:44
@miaulalala miaulalala merged commit 9afbad3 into master Mar 3, 2026
211 of 222 checks passed
@miaulalala miaulalala deleted the fix/noid/dav-capabilities-psalm-return-type branch March 3, 2026 19:48
@cristianscheid
Copy link
Copy Markdown
Contributor Author

Just documenting that stable29, stable30, stable31, and stable32 should now also be fixed by the PRs below (already merged), preventing the psalm errors.

#58706 [stable29]
#58691 [stable30]
#58692 [stable31]
#58693 [stable32]

@nextcloud-bot nextcloud-bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants