Skip to content

refactor: use strict comparison operator#57882

Merged
Altahrim merged 1 commit intomasterfrom
useStrictComparisonOperator
Jan 29, 2026
Merged

refactor: use strict comparison operator#57882
Altahrim merged 1 commit intomasterfrom
useStrictComparisonOperator

Conversation

@solracsf
Copy link
Copy Markdown
Member

@solracsf solracsf commented Jan 28, 2026

Summary

Found no good reason for any of these to not be strict.
Not sure if this is a refactor or a fix 😆

Checklist

@solracsf solracsf added this to the Nextcloud 34 milestone Jan 28, 2026
@solracsf solracsf added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Jan 28, 2026
@solracsf solracsf force-pushed the useStrictComparisonOperator branch 2 times, most recently from dff849b to 427bbff Compare January 28, 2026 16:12
Copy link
Copy Markdown
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment thread lib/private/Files/Storage/Wrapper/Quota.php Outdated
@solracsf solracsf force-pushed the useStrictComparisonOperator branch 3 times, most recently from 1122f2a to d50b8b8 Compare January 28, 2026 18:22
@solracsf solracsf added the 2. developing Work in progress label Jan 28, 2026
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the useStrictComparisonOperator branch from 818ed94 to 0803350 Compare January 28, 2026 20:12
@solracsf solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 28, 2026
@solracsf solracsf marked this pull request as ready for review January 28, 2026 20:24
@solracsf solracsf requested a review from a team as a code owner January 28, 2026 20:24
@solracsf solracsf requested review from Altahrim, icewind1991, leftybournes and sorbaugh and removed request for a team January 28, 2026 20:24
@Altahrim Altahrim merged commit 7f71b46 into master Jan 29, 2026
208 of 210 checks passed
@Altahrim Altahrim deleted the useStrictComparisonOperator branch January 29, 2026 08:20
@Altahrim Altahrim removed the 3. to review Waiting for reviews label Jan 29, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants