refactor(settings): use NcAppNavigation for the settings navigation#57791
Merged
refactor(settings): use NcAppNavigation for the settings navigation#57791
NcAppNavigation for the settings navigation#57791Conversation
susnux
added
3. to review
susnux
requested review from
CarlSchwan,
leftybournes,
nfebe,
salmart-dev,
sorbaugh and
szaimen
and removed request for
a team
9 tasks
susnux
force-pushed
the
refactor/settings-navigation-vue
branch
from
70d45fb to
e4fcdd7
Compare
CarlSchwan
approved these changes
Jan 26, 2026
Migrate away from jQuery and Snap.js for the navigation. This is required to finally drop both dependencies. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/settings-navigation-vue
branch
from
e4fcdd7 to
32590cc
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/settings-navigation-vue
branch
from
32590cc to
e4522ca
Compare
8 tasks
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate away from jQuery and Snap.js for the navigation.
This is required to finally drop both dependencies.
Checklist
3. to review, feature component)stable32)